Skip to content

feat: resolve emitDecoratorMetadata in tsconfig#439

Merged
Boshen merged 1 commit intomainfrom
04-02-feat_resolve_emitdecoratormetadata_in_tsconfig
Apr 2, 2025
Merged

feat: resolve emitDecoratorMetadata in tsconfig#439
Boshen merged 1 commit intomainfrom
04-02-feat_resolve_emitdecoratormetadata_in_tsconfig

Conversation

@Brooooooklyn
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn requested a review from Copilot April 2, 2025 06:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the tsconfig property emitDecoratorMetadata by introducing a corresponding field and accessor methods in the serde representation and trait definitions.

  • Added a new field and associated getter/setter in the tsconfig serde implementation.
  • Extended the CompilerOptions trait with getter/setter methods for emitDecoratorMetadata.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tsconfig_serde.rs Added a field for emitDecoratorMetadata and its getter/setter.
src/tsconfig.rs Extended the CompilerOptions trait with emitDecoratorMetadata methods.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Performance Report

Merging #439 will not alter performance

Comparing 04-02-feat_resolve_emitdecoratormetadata_in_tsconfig (ab01835) with main (69ba3ed)

Summary

✅ 3 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 94.67%. Comparing base (69ba3ed) to head (ab01835).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tsconfig_serde.rs 0.00% 6 Missing ⚠️
src/tsconfig.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   95.02%   94.67%   -0.36%     
==========================================
  Files          13       13              
  Lines        2696     2706      +10     
==========================================
  Hits         2562     2562              
- Misses        134      144      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen merged commit b271145 into main Apr 2, 2025
18 checks passed
@Boshen Boshen deleted the 04-02-feat_resolve_emitdecoratormetadata_in_tsconfig branch April 2, 2025 06:56
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Boshen pushed a commit that referenced this pull request Apr 2, 2025
## 🤖 New release

* `oxc_resolver`: 5.0.1 -> 5.1.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[5.1.0](oxc_resolver-v5.0.1...oxc_resolver-v5.1.0)
- 2025-04-02

### <!-- 0 -->Features

- resolve emitDecoratorMetadata in tsconfig
([#439](#439))

### <!-- 3 -->Documentation

- fix an incorrect comment on `Context::missing_dependencies`
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
@oxc-bot oxc-bot mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants