Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
0034181 to
4a78c0d
Compare
CodSpeed Performance ReportMerging #219 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 11 11
Lines 2306 2306
=======================================
Hits 2235 2235
Misses 71 71 ☔ View full report in Codecov by Sentry. |
4a78c0d to
a94a984
Compare
Member
|
We need another benchmark set where it doesn't reuse the cache. |
f77fa0b to
8013161
Compare
8013161 to
1013c5e
Compare
Member
|
codspeed doesn't measure any syscalls, but this button is not showing anything either 
|
Member
Author
|
@Boshen I can see performance changes on my macOS:
|
JounQin
pushed a commit
that referenced
this pull request
Jul 6, 2025
* bench: add symlink fixtures (#219) * perf: use custom canonicalize impl to avoid usless syscall (#220) Reduce one redundant fs::symlink_metadata system call. * ci: pin crate-ci/typos version * fix: remove `#[cfg(target_os = "windows")]` logic in `canonicalize` (#221) fix: missed changes before #220 merged * chore: update `cargo deny` (#222) --------- Co-authored-by: LongYinan <lynweklm@gmail.com> Co-authored-by: Boshen <boshenc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.