Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 20 20
Lines 3980 3980
=======================================
Hits 3653 3653
Misses 327 327 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-specific path normalization issue where absolute paths with forward slashes were not being converted to backslashes when symlinks: false is configured. Previously, the path normalization only happened through the canonicalize function when symlinks: true, but paths with forward slashes would be returned as-is when symlinks were disabled.
Changes:
- Added Windows-specific path normalization logic in
load_realpathto convert forward slashes to backslashes even whensymlinks: false - Added a test case to verify that both resolver configurations (with and without symlinks) properly normalize Windows paths
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib.rs | Added conditional Windows path normalization in load_realpath using components().collect() when forward slashes are detected |
| src/tests/windows.rs | Added test forward_slash_path_resolved_to_backslash to verify path normalization works for both symlinks: true and symlinks: false |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing 
Footnotes
|
This PR fixes the failing test in rolldown/rolldown#8483.
slightly related #345