Skip to content

refactor(transformer/using): add more comments and amend some#9673

Merged
graphite-app[bot] merged 1 commit into
mainfrom
03-11-refactor_transformer_using_add_more_comments_and_amend_some
Mar 11, 2025
Merged

refactor(transformer/using): add more comments and amend some#9673
graphite-app[bot] merged 1 commit into
mainfrom
03-11-refactor_transformer_using_add_more_comments_and_amend_some

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Follow-on after #9310. Pure refactor. Add more comments, and move/amend some. Correct the link to the Babel plugin.

@overlookmotel Graphite App

overlookmotel commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 11, 2025 06:43
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 11, 2025 06:43
@codspeed-hq

codspeed-hq Bot commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9673 will not alter performance

Comparing 03-11-refactor_transformer_using_add_more_comments_and_amend_some (06bd816) with main (ce810ae)

Summary

✅ 39 untouched benchmarks

@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@overlookmotel overlookmotel requested review from camc314 and removed request for Dunqing March 11, 2025 07:08
@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
camc314
camc314 reviewed Mar 11, 2025
View reviewed changes
Comment thread crates/oxc_transformer/src/proposals/explicit_resource_management.rs
@camc314 camc314 changed the base branch from 03-11-refactor_transformer_using_re-order_imports to graphite-base/9673 March 11, 2025 09:38
@camc314 camc314 force-pushed the graphite-base/9673 branch from 12a49cc to ce810ae Compare March 11, 2025 09:43
@camc314 camc314 force-pushed the 03-11-refactor_transformer_using_add_more_comments_and_amend_some branch from 500e0ad to 7fa8f6b Compare March 11, 2025 09:43
@camc314 camc314 changed the base branch from graphite-base/9673 to main March 11, 2025 09:44
@camc314 camc314 force-pushed the 03-11-refactor_transformer_using_add_more_comments_and_amend_some branch from 7fa8f6b to cd610fa Compare March 11, 2025 09:44
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app

graphite-app Bot commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
refactor(transformer/using): add more comments and amend some (#9673)
06bd816 
Follow-on after #9310. Pure refactor. Add more comments, and move/amend some. Correct the link to the Babel plugin.
@graphite-app graphite-app Bot force-pushed the 03-11-refactor_transformer_using_add_more_comments_and_amend_some branch from cd610fa to 06bd816 Compare March 11, 2025 09:54
@graphite-app graphite-app Bot merged commit 06bd816 into main Mar 11, 2025
@graphite-app graphite-app Bot deleted the 03-11-refactor_transformer_using_add_more_comments_and_amend_some branch March 11, 2025 10:10
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314