Skip to content

feat(linter): add jest/no-confusing-set-timeout#938

Merged
mysteryven merged 5 commits into
oxc-project:mainfrom
eryue0220:feat/no-confusing-set-timeout
Oct 9, 2023
Merged

feat(linter): add jest/no-confusing-set-timeout#938
mysteryven merged 5 commits into
oxc-project:mainfrom
eryue0220:feat/no-confusing-set-timeout

Conversation

@eryue0220

Copy link
Copy Markdown
Contributor

Add jest new rule no-confusing-set-timeout. More rule details can read this link.

@eryue0220 eryue0220 marked this pull request as draft September 26, 2023 15:47
@github-actions github-actions Bot added the A-linter Area - Linter label Sep 26, 2023
@codspeed-hq

codspeed-hq Bot commented Sep 26, 2023

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #938 will not alter performance

Comparing eryue0220:feat/no-confusing-set-timeout (e814676) with main (61bc142)

Summary

✅ 18 untouched benchmarks

@eryue0220

Copy link
Copy Markdown
Contributor Author

Fight with benchmark 😓

Comment thread crates/oxc_linter/src/rules/jest/no_confusing_set_timeout.rs Outdated
@eryue0220 eryue0220 marked this pull request as ready for review October 9, 2023 10:44
@eryue0220 eryue0220 changed the title [WIP] feat(linter): add jest/no-confusing-set-timeout feat(linter): add jest/no-confusing-set-timeout Oct 9, 2023
@Boshen Boshen requested a review from mysteryven October 9, 2023 11:13

@mysteryven mysteryven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulates for passing the benchmark finally:) Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants