fix(transformer/decorator): decoration disappear due to incorrect statement address#9062
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9062 will not alter performanceComparing Summary
|
27b2fe4 to
0abf0d8
Compare
403e9ae to
19fdf89
Compare
0abf0d8 to
cac5d47
Compare
overlookmotel
left a comment
There was a problem hiding this comment.
I rebased on latest main to fix merge conflicts and tidied up whitespace in test fixtures, but made no substantive changes. I'll follow up with a couple of style nit things in separate PRs.
Merge activity
|
cac5d47 to
bad08cf
Compare
|
@Dunqing You were not keen on passing A way to avoid that would be to record the But personally I think the way you have it now is good. The call chain is short, these functions have few parameters, and those params are all small (8 bytes each). So probably It makes very little difference either way - this is micro-optimization stuff - but just mentioning it as you said you didn't like passing it as a param. |
…ess::address` (#9264) Follow-on after #9062. Pure refactor. In all these cases, `class` / `export` is a `Box`, so we can use `class.address()` to get the address, instead of `Address::from_ptr(class.as_ref())`. These 2 both do exactly the same thing, but personally I think it's preferable to avoid `Address::from_ptr` where we can. `Address::GetAddress` always produces a valid, permanent `Address`, whereas `Address::from_ptr` is a bit of a hack and can give you an unreliable `Address` in some cases. If we only use `Address::from_ptr` where we *have* to, it's easier to see where we have a potential sources of bugs.
Follow-on after #9062. Just a small code style refactor. Make `&mut Class` the first param of these methods, because it's the "main" input to the function. The `Address` is a less important param, so can go after it.
close: #9058
close: #9129