fix(oxc_language_server): use file_path instead of uri_path#8736
Merged
Sysix merged 1 commit intooxc-project:mainfrom Jan 26, 2025
Merged
fix(oxc_language_server): use file_path instead of uri_path#8736Sysix merged 1 commit intooxc-project:mainfrom
file_path instead of uri_path#8736Sysix merged 1 commit intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8736 will not alter performanceComparing Summary
|
Sysix
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8594
This is because previously, oxlintrc.path was determined by
path.canonicalize().unwrap_or_else(|_| path.to_path_buf()), but after #8214, it was changed topath.to_path_buf(). As a result,\\?\D:\shulaodabecameD:\shulaoda. This caused the conditionuri_path.starts_with(gitignore.path())to evaluate astrue, preventing the bypass of theis_ignorecheck and exposing the original code issue.oxc/crates/oxc_language_server/src/main.rs
Lines 531 to 533 in b1499e6