ci(lint): run clippy in release mode#8541
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
da60a47 to
70ce295
Compare
|
Confirmed the Clippy CI task did error when this PR based on current main (i.e. before #8539 fixed the lint error): https://github.com/oxc-project/oxc/actions/runs/12808503116/job/35711378282?pr=8541 @Boshen Is this worthwhile? Maybe we should only run it in pre-release process rather than on every PR? |
CodSpeed Performance ReportMerging #8541 will not alter performanceComparing Summary
|
Merge activity
|
CI Clippy task catch lint errors which only appear in release mode (e.g. the one fixed in #8539). Add a profile for this. `cargo clippy --profile dev-no-debug-assertions` is about 35% faster than `cargo clippy --release` (and is slightly faster than plain `cargo clippy`) but catches the same problems. This slows down the Clippy CI task, but it still remains faster than running conformance, so I don't think it's likely to slow down CI overall.
66bf735 to
72f425f
Compare
70ce295 to
1d4c7a1
Compare
CI Clippy task catch lint errors which only appear in release mode (e.g. the one fixed in #8539).
Add a profile for this.
cargo clippy --profile dev-no-debug-assertionsis about 35% faster thancargo clippy --release(and is slightly faster than plaincargo clippy) but catches the same problems.This slows down the Clippy CI task, but it still remains faster than running conformance, so I don't think it's likely to slow down CI overall.