Skip to content

feat(ast)!: remove unused and not useful ContentHash#8483

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-14-feat_ast_remove_unused_and_not_useful_contenthash_
Jan 14, 2025
Merged

feat(ast)!: remove unused and not useful ContentHash#8483
graphite-app[bot] merged 1 commit intomainfrom
01-14-feat_ast_remove_unused_and_not_useful_contenthash_

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Jan 14, 2025

ContentEq is preferred.

Copy link
Copy Markdown
Member Author

Boshen commented Jan 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Jan 14, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Jan 14, 2025

Merge activity

Boshen added a commit that referenced this pull request Jan 14, 2025
@Boshen Boshen force-pushed the 01-14-feat_ast_remove_unused_and_not_useful_contenthash_ branch from f3f3c99 to 2514cad Compare January 14, 2025 09:46
@Boshen Boshen force-pushed the 01-14-feat_ast_remove_unused_and_not_useful_contenthash_ branch from 2514cad to 7eb6ccd Compare January 14, 2025 09:53
@graphite-app graphite-app Bot merged commit 7eb6ccd into main Jan 14, 2025
@graphite-app graphite-app Bot deleted the 01-14-feat_ast_remove_unused_and_not_useful_contenthash_ branch January 14, 2025 10:00
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #8483 will not alter performance

Comparing 01-14-feat_ast_remove_unused_and_not_useful_contenthash_ (7eb6ccd) with main (c83ce5c)

Summary

✅ 32 untouched benchmarks

Boshen added a commit that referenced this pull request Jan 14, 2025
## [0.46.0] - 2025-01-14

- 7eb6ccd ast: [**BREAKING**] Remove unused and not useful `ContentHash`
(#8483) (Boshen)

### Features

- 8accfef minifier: Minify `var x; void x` -> `void 0` (#8466) (Boshen)
- 870a583 minifier: Fold `false['toString']` (#8447) (Boshen)
- 4ad695d napi/minify: Implement napi (#8478) (Boshen)
- 9d550aa span: Add `Atom::r#static` (#8479) (_Kerman)

### Bug Fixes

- 4071878 isolated-declarations: Retain `declare` declarations when they
are exported (#8477) (Dunqing)
- 7ee7634 isolated-declarations: Import statement disappears when import
binding is referenced in nested `typeof` (#8476) (Dunqing)
- 7252cb0 isolated-declarations: Unexpected error when global `Symbol`
as property key (#8475) (Dunqing)
- 4c6675c minifier: Do not convert while to fors in DCE (#8484) (Boshen)
- 1d6e84d minifier: Fix incorrect `null.toString()` and `1n.toString()`
(#8464) (Boshen)
- 25d4bf9 minifier: Remove usage of empty spans (#8462) (Boshen)
- dd64340 minifier: Keep `return undefined` in async generator function
(#8439) (Boshen)
- c444de8 transformer/arrow-functions: Transform `this` and `super`
incorrectly in async arrow function (#8435) (Dunqing)
- 270245f transformer/typescript: Correct the semantic for
TSImportEqualsDeclaration transformation (#8463) (Dunqing)
- 2a400d6 transformer/typescript: Retain TSImportEqualsDeclaration when
it is exported (Dunqing)
- ab694b0 transformer/typescript: Retain `TSImportEqualsDeclaration` in
`namespace` when its binding has been referenced or
`onlyRemoveTypeImports` is true (#8458) (Dunqing)

### Performance

- 7a8200c mangler: Allocate base54 name without heap allocation (#8472)
(Boshen)
- 31dac22 mangler: Allocate data in arena (#8471) (Boshen)
- 8fc238a minifier: Merge `Normalize` and `RemoveSyntax` pass (#8467)
(Boshen)
- 372eb09 minifier: Preallocate mangler's semantic data (#8451) (Boshen)

### Refactor

- 6e64eef codegen: Remove `match_expression!` (#8450) (Boshen)
- de5b288 span: Rename `Atom::new_const` method (#8480) (overlookmotel)
- c83ce5c transformer/typescript: Improve transforming namespace (#8459)
(Dunqing)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Boshen pushed a commit that referenced this pull request Jan 15, 2025
…8512)

#8483 removed codegen-ed impls of `ContentHash` for AST nodes, because `ContentHash` is not useful. Complete the removal by removing `ContentHash` trait definition, and all remaining references to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant