fix(linter): rule no-restricted-imports: improve diagnostics#8113
Merged
Sysix merged 33 commits intooxc-project:mainfrom Feb 8, 2025
Sysix:fix-linter-no-restricted-imports-improve-diagnostics
Merged
fix(linter): rule no-restricted-imports: improve diagnostics#8113Sysix merged 33 commits intooxc-project:mainfrom Sysix:fix-linter-no-restricted-imports-improve-diagnostics
no-restricted-imports: improve diagnostics#8113Sysix merged 33 commits intooxc-project:mainfrom
Sysix:fix-linter-no-restricted-imports-improve-diagnostics
Conversation
… option inside `patterns`
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
no-restricted-imports: imporve diagnostics
no-restricted-imports: imporve diagnosticsno-restricted-imports: improve diagnostics
CodSpeed Performance ReportMerging #8113 will not alter performanceComparing Summary
|
…ld regex in `from_configuration`
Boshen
pushed a commit
that referenced
this pull request
Dec 31, 2024
Probably a breaking change. this is needed for the diagnostic in `no-restricted-imports`: #8113 you can see the eslint expection here: https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-imports.js#L487-L517 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
…-linter-no-restricted-imports-improve-diagnostics
Member
Author
|
@camc314 did you had time to look at this PR :)? |
Member
Merge activity
|
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
I looked manually at the expected error messages from eslint: https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-imports.js and updated the rule to match the message. Almost all spans are correctly too,I think only one or two use-cases are missing. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked manually at the expected error messages from eslint: https://github.com/eslint/eslint/blob/main/tests/lib/rules/no-restricted-imports.js and updated the rule to match the message.
Almost all spans are correctly too,I think only one or two use-cases are missing.