test(transformer/nullish-coalescing): failing test#8051
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 21, 2024
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
Dec 20, 2024
Contributor
Merge activity
|
Boshen
pushed a commit
that referenced
this pull request
Dec 21, 2024
Add failing test for nullish coalescing operator. The output is correct, but temp var is created in wrong scope. My guess is that it needs to use `current_hoist_scope_id`, not `current_scope_id`. This test from class properties also shows the same problem: https://github.com/oxc-project/oxc/blob/ac097e916051288cc982136e4e22c2766cb4bd91/tasks/transform_conformance/snapshots/oxc.snap.md?plain=1#L20-L35
44bd7d2 to
74cb306
Compare
Add failing test for nullish coalescing operator. The output is correct, but temp var is created in wrong scope. My guess is that it needs to use `current_hoist_scope_id`, not `current_scope_id`. This test from class properties also shows the same problem: https://github.com/oxc-project/oxc/blob/ac097e916051288cc982136e4e22c2766cb4bd91/tasks/transform_conformance/snapshots/oxc.snap.md?plain=1#L20-L35
74cb306 to
3d83396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add failing test for nullish coalescing operator. The output is correct, but temp var is created in wrong scope.
My guess is that it needs to use
current_hoist_scope_id, notcurrent_scope_id.This test from class properties also shows the same problem:
oxc/tasks/transform_conformance/snapshots/oxc.snap.md
Lines 20 to 35 in ac097e9