Skip to content

fix(linter): false positive in exhaustive-deps#7626

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-fix_linter_false_positive_in_exhaustive-deps
Dec 4, 2024
Merged

fix(linter): false positive in exhaustive-deps#7626
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-fix_linter_false_positive_in_exhaustive-deps

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 3, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review December 3, 2024 22:07
Copy link
Contributor Author

camc314 commented Dec 3, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7626 will improve performances by 3.15%

Comparing c/12-03-fix_linter_false_positive_in_exhaustive-deps (e824501) with main (543df6e)

Summary

⚡ 1 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main c/12-03-fix_linter_false_positive_in_exhaustive-deps Change
semantic[cal.com.tsx] 29 ms 28.1 ms +3.15%

@Boshen Boshen force-pushed the c/12-03-fix_linter_update_reporting_spans_for_exhaustive-deps branch 2 times, most recently from 509bda3 to bd639fe Compare December 4, 2024 00:02
@Boshen Boshen force-pushed the c/12-03-fix_linter_false_positive_in_exhaustive-deps branch from f7a1b1c to df4dfeb Compare December 4, 2024 00:02
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link
Member

Boshen commented Dec 4, 2024

Merge activity

  • Dec 3, 8:57 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 8:57 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 9:05 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-03-fix_linter_update_reporting_spans_for_exhaustive-deps branch from bd639fe to 8a68ef4 Compare December 4, 2024 01:58
@Boshen Boshen force-pushed the c/12-03-fix_linter_false_positive_in_exhaustive-deps branch from df4dfeb to e824501 Compare December 4, 2024 01:59
Base automatically changed from c/12-03-fix_linter_update_reporting_spans_for_exhaustive-deps to main December 4, 2024 02:03
@graphite-app graphite-app bot merged commit e824501 into main Dec 4, 2024
@graphite-app graphite-app bot deleted the c/12-03-fix_linter_false_positive_in_exhaustive-deps branch December 4, 2024 02:05
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants