Skip to content

feat(linter): output rules to json array#7574

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-feat_linter_output_rules_to_json_array
Dec 2, 2024
Merged

feat(linter): output rules to json array#7574
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-feat_linter_output_rules_to_json_array

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 1, 2024

closes #7517

cc @Sysix

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review December 1, 2024 20:56
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Dec 1, 2024
@camc314 camc314 force-pushed the c/12-01-feat_linter_output_rules_to_json_array branch from ec0f111 to a385d69 Compare December 1, 2024 20:58
@Sysix
Copy link
Copy Markdown
Member

Sysix commented Dec 1, 2024

thanks you @camc314 ❤️

I also tried to implement it today and found some problems on the way.
For the moment this looks great 👍

For the future I would like to have an OutputFormatter interface.
Then maybe we can handle all the use cases for the different --format options and other flag combinations

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #7574 will not alter performance

Comparing c/12-01-feat_linter_output_rules_to_json_array (275d625) with main (4e3044e)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen requested a review from Sysix December 2, 2024 03:11
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 2, 2024
Copy link
Copy Markdown
Member

Boshen commented Dec 2, 2024

Merge activity

  • Dec 1, 10:13 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 10:13 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 1, 10:26 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen
Copy link
Copy Markdown
Member

Boshen commented Dec 2, 2024

@Sysix Feel free to add more meta data for your requirements.

@Boshen Boshen force-pushed the c/12-01-feat_linter_output_rules_to_json_array branch from a385d69 to 275d625 Compare December 2, 2024 03:18
@graphite-app graphite-app Bot merged commit 275d625 into main Dec 2, 2024
@graphite-app graphite-app Bot deleted the c/12-01-feat_linter_output_rules_to_json_array branch December 2, 2024 03:26
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: API for eslint-plugin-oxlint

3 participants