fix(apps/oxlint): incorrect matching in .oxlintignore#7566
Merged
Boshen merged 2 commits intooxc-project:mainfrom Dec 2, 2024
Merged
fix(apps/oxlint): incorrect matching in .oxlintignore#7566Boshen merged 2 commits intooxc-project:mainfrom
.oxlintignore#7566Boshen merged 2 commits intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Boshen
reviewed
Dec 1, 2024
Member
Boshen
left a comment
There was a problem hiding this comment.
Can we add a test for catching regressions?
Contributor
|
Today I test it too, and got same problem but with "ignorePatterns" from config |
0698aed to
fca6c44
Compare
fca6c44 to
59707a9
Compare
This was referenced Dec 6, 2024
github-merge-queue Bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Dec 6, 2024
### Description closes #3065 Related to oxc-project/oxc#7566 and oxc-project/oxc#7696 Changelog: https://github.com/oxc-project/oxc/releases/tag/oxlint_v0.14.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was discovered while updating test cases in
rolldown.In the
.oxlintignorefile, we have:When running the command by
lint-staged:oxlint -c .oxlintrc.json --ignore-path=.oxlintignore --deny-warnings "tests/function/main.js"The file
main.jsgets linted despite being ignored. This happens because, before usingGitignore::new, we converted paths to absolute paths, causing the patterntests/**to not matchD:/rolldown/tests/function/main.jscorrectly.oxc/apps/oxlint/src/lint.rs
Lines 60 to 78 in c61a383