Skip to content

chore(doc): replace main/master to tag/commit to make the url always accessible#7298

Merged
Boshen merged 1 commit into
oxc-project:mainfrom
ShuiRuTian:use-tag-or-commit-rather-than-main-for-url
Nov 16, 2024
Merged

chore(doc): replace main/master to tag/commit to make the url always accessible#7298
Boshen merged 1 commit into
oxc-project:mainfrom
ShuiRuTian:use-tag-or-commit-rather-than-main-for-url

Conversation

@ShuiRuTian

@ShuiRuTian ShuiRuTian commented Nov 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #7291

The match relationship is :

 {
    "oxc-project/oxc": "main",
    "cvazac/eslint-plugin-react-perf": "9bfa930661a23218f5460ebd39d35d76ccdb5724",
    "DefinitelyTyped/DefinitelyTyped": "b5dc32740d9b45d11cff9b025896dd333c795b39",
    "estree/estree": "e6015c4c63118634749001b1cd1c3f7a0388f16e",
    "fregante/eslint-formatters": "ae1fd9748596447d1fd09625c33d9e7ba9a3d06d",
    "javascript-compiler-hints/compiler-notations-spec": "c14f7e197cb225c9eee877143536665ce3150712",
    "mozilla-spidermonkey/jsparagus": "24004745a8ed4939fc0dc7332bfd1268ac52285f",
    "privatenumber/minification-benchmarks": "d8d54ceeb206d318fa288b152904adf715b076b2",
    "tc39/source-map": "1930e58ffabefe54038f7455759042c6e3dd590e",
    "tc39/test262": "05c45a4c430ab6fee3e0c7f0d47d8a30d8876a6d",
    "biomejs/biome": "cli/v1.9.4",
    "eslint-community/eslint-plugin-promise": "v7.1.0",
    "eslint-community/eslint-plugin-n": "v17.13.2",
    "rollup/plugins": "pluginutils-v5.1.3",
    "rome/tools": "lsp/v0.28.0",
    "A11yance/aria-query": "v5.3.2",
    "babel/babel": "v7.26.2",
    "denoland/deno_graph": "0.84.0",
    "eslint/eslint": "v9.9.1",
    "evanw/esbuild": "v0.24.0",
    "facebook/react": "v18.3.1",
    "gajus/eslint-plugin-jsdoc": "v50.5.0",
    "getsentry/rust-sourcemap": "9.1.0",
    "google/closure-compiler": "v20240609",
    "guybedford/es-module-lexer": "1.5.4",
    "import-js/eslint-plugin-import": "v2.29.1",
    "jest-community/eslint-plugin-jest": "v28.9.0",
    "jsx-eslint/eslint-plugin-jsx-a11y": "v6.9.0",
    "jsx-eslint/eslint-plugin-react": "v7.37.2",
    "Kilian/electron-to-chromium": "v1.5.60",
    "lukastaegert/eslint-plugin-tree-shaking": "v1.12.2",
    "microsoft/TypeScript": "v5.6.3",
    "nicolo-ribaudo/babel": "v7.25.8",
    "nodevault/node-vault": "v0.10.2",
    "prettier/prettier": "3.3.3",
    "ratel-rust/ratel-core": "v0.7.0",
    "rolldown-rs/rolldown": "v0.14.0",
    "rust-lang/rust": "1.82.0",
    "sindresorhus/eslint-plugin-unicorn": "v56.0.0",
    "terser/terser": "v5.9.0",
    "typescript-eslint/typescript-eslint": "v8.9.0",
    "vercel/next.js": "v15.0.2",
    "veritem/eslint-plugin-vitest": "v1.1.9",
}

@graphite-app

graphite-app Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions Bot added A-linter Area - Linter A-parser Area - Parser A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 15, 2024
@codspeed-hq

codspeed-hq Bot commented Nov 15, 2024 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #7298 will not alter performance

Comparing ShuiRuTian:use-tag-or-commit-rather-than-main-for-url (b18dc74) with main (cf99be0)

Summary

✅ 30 untouched benchmarks

@ShuiRuTian ShuiRuTian mentioned this pull request Nov 15, 2024
Closed
@Boshen

Boshen commented Nov 15, 2024

Copy link
Copy Markdown
Member

Errors in ./crates/oxc_prettier/README.md

@ShuiRuTian

ShuiRuTian commented Nov 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Good catch, it's because the tag of following repo does not start with "v"

Write a script to ping the url and all should return 200 now.

@overlookmotel

overlookmotel commented Nov 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)

(see the "Check links" CI task)

@ShuiRuTian ShuiRuTian force-pushed the use-tag-or-commit-rather-than-main-for-url branch from 37ffc4c to b18dc74 Compare November 16, 2024 12:57
@ShuiRuTian

ShuiRuTian commented Nov 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Only one still failing: https://github.com/prettier/prettier/tree/v3.3.3/tests/format/js (the v shouldn't be there)

(see the "Check links" CI task)

Thanks, it's actually because my force-push was failed on my local machine due to net issue.

I wrote a script to repalce url, so the easier way is to rewrote everything and make a force push

@Boshen Boshen merged commit cf3415b into oxc-project:main Nov 16, 2024
@overlookmotel

overlookmotel commented Nov 16, 2024

Copy link
Copy Markdown
Member

Nice one! Thanks very much for doing this.

Dunqing pushed a commit that referenced this pull request Nov 17, 2024
@ShuiRuTian @Dunqing
chore(doc): replace main/master to tag/commit to make the url always …
d4b24d5 
…accessible (#7298)
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@ShuiRuTian @Dunqing
chore(doc): replace main/master to tag/commit to make the url always …
fa13db9 
…accessible (#7298)
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@ShuiRuTian @Dunqing
chore(doc): replace main/master to tag/commit to make the url always …
17586c3 
…accessible (#7298)
@Dunqing Dunqing mentioned this pull request Jun 12, 2026
Merged
graphite-app Bot pushed a commit that referenced this pull request Jun 12, 2026
@Dunqing
docs(lexer): correct reference link for byte_handlers! (#23313)
e6bdfd4 
#7298 changed from `master` to the `0.7.0` tag, but there are significant differences in between. This PR updates to the commit that points to the last commit in the master branch.
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@Dunqing @camc314
docs(lexer): correct reference link for byte_handlers! (#23313)
7d587ad 
#7298 changed from `master` to the `0.7.0` tag, but there are significant differences in between. This PR updates to the commit that points to the last commit in the master branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Doc] the url of some file in some repo should have a specific commit or tag rather than branch

3 participants

@ShuiRuTian @Boshen @overlookmotel