feat(lint-unicorn): add rule prefer set has#7075
Merged
Boshen merged 4 commits intooxc-project:mainfrom Nov 25, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #7075 will not alter performanceComparing Summary
|
camc314
reviewed
Nov 1, 2024
camc314
reviewed
Nov 1, 2024
camchenry
approved these changes
Nov 2, 2024
Member
camchenry
left a comment
There was a problem hiding this comment.
looks pretty good, just had some suggestions on a few things, but overall I think this rule makes sense to me!
3237900 to
fc9033d
Compare
camchenry
approved these changes
Nov 4, 2024
fc9033d to
c379e24
Compare
f3608f2 to
c7016d8
Compare
af80d18 to
57f397f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementing the rule prefer set has from unicorn.
I put the fix as dangerous fix because they was no test for the fix on the unicorn part. I did add some test for this but i'm not sure that i'm covering everything.