refactor(ast_tools): use spaces not tabs in TS type defs#6682
Closed
overlookmotel wants to merge 1 commit into10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defsfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 19, 2024
Member
Author
This was referenced Oct 19, 2024
6205d3a to
9ca8f75
Compare
e1c7f40 to
af4c74e
Compare
CodSpeed Performance ReportMerging #6682 will not alter performanceComparing Summary
|
This was referenced Oct 19, 2024
ottomated
reviewed
Oct 19, 2024
Contributor
ottomated
left a comment
There was a problem hiding this comment.
Again, do we care about matching wasm-bindgen's style? When this is being rendered as a text file directly it'll have a formatting step run on it so this seems unnecessary
9ca8f75 to
01b9e83
Compare
af4c74e to
e4e1deb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #6404. Use spaces instead of tabs in TS type defs, to match the code style
wasm_bindgenuses for the types it generates.