Skip to content

feat(linter): add unicorn/prefer-math-min-max#6621

Merged
DonIsaac merged 11 commits intooxc-project:mainfrom
LBrian:feat/684-unicorn-prefer-math-min-max
Oct 20, 2024
Merged

feat(linter): add unicorn/prefer-math-min-max#6621
DonIsaac merged 11 commits intooxc-project:mainfrom
LBrian:feat/684-unicorn-prefer-math-min-max

Conversation

@LBrian
Copy link
Copy Markdown
Contributor

@LBrian LBrian commented Oct 16, 2024

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 16, 2024
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing - this is great!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #6621 will not alter performance

Comparing LBrian:feat/684-unicorn-prefer-math-min-max (61632e8) with main (e340424)

Summary

✅ 30 untouched benchmarks

Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 requested a review from DonIsaac October 17, 2024 10:09
Copy link
Copy Markdown
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice addition! Just some minor comments, but overall looks good.

@DonIsaac
Copy link
Copy Markdown
Contributor

LGTM, once both Cams are happy we can merge

@DonIsaac DonIsaac changed the title feat(linter): eslint-plugin-unicorn(unicorn/prefer-math-min-max) feat(linter): add unicorn/prefer-math-min-max Oct 17, 2024
@camchenry
Copy link
Copy Markdown
Member

@LBrian sorry, my suggestion was not syntactically correct, the code is missing a bracket now it looks like

@LBrian
Copy link
Copy Markdown
Contributor Author

LBrian commented Oct 18, 2024

@LBrian sorry, my suggestion was not syntactically correct, the code is missing a bracket now it looks like

All good. I noticed that and fixed it in my commit.

@DonIsaac DonIsaac merged commit af25752 into oxc-project:main Oct 20, 2024
Boshen added a commit that referenced this pull request Oct 21, 2024
## [0.10.1] - 2024-10-21

### Features

- af25752 linter: Add `unicorn/prefer-math-min-max` (#6621) (Brian Liu)
- 5095f02 linter: Added fixer for duplicate prefix in valid title jest
rule (#6699) (Tapan Prakash)
- e9976d4 linter: Add title whitespace fixer for jest valid title rule
(#6669) (Tapan Prakash)
- 45f02d5 linter: Add `unicorn/consistent-empty-array-spread` (#6695)
(Brian Liu)
- 01a35bb linter/eslint: Show ignore patterns in `eslint/no-unused-vars`
diagnostic messages (#6696) (DonIsaac)

### Bug Fixes

- 1bcd707 editor: Update config sent to language server (#6724)
(Nicholas Rayburn)
- ce25c45 linter: Panic in `disable-directives` (#6677) (dalaoshu)
- a5de230 linter/import: `import/no-duplicates` handles namespace
imports correctly (#6694) (DonIsaac)
- b0b6ac7 linter/no-cond-assign: False positive when assignment is in
body statement (#6665) (camchenry)

### Performance

- 6a76ea8 linter/no-unused-vars: Use default IgnorePattern when /^_/ is
provided as a pattern (#6697) (DonIsaac)

### Refactor

- d6609e9 linter: Use `run_on_jest_node` for existing lint rules (#6722)
(camchenry)
- 97195ec linter: Add `run_on_jest_node` to run rules on only jest nodes
(#6721) (camchenry)
- 155fe7e linter: Allow `Semantic` to be passed for collecting Jest
nodes (#6720) (camchenry)
- ad8f281 linter: Use iter for collecting jest nodes (#6719) (camchenry)
- dc19a8f linter: Use iterator for collecting jest imports (#6718)
(camchenry)
- 29c1447 linter: `jest/valid-title` fixer to use `Span::shrink` method
(#6703) (Tapan Prakash)
- 2eb984a linter: Add missing `should_run` implementations (#6666)
(camchenry)
- 23f88b3 linter/import: Better diagnostic messages for
`import/no-duplicates` (#6693) (DonIsaac)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants