Skip to content

test(regex): add ContentEq tests#6409

Closed
DonIsaac wants to merge 2 commits intomainfrom
don/10-09-test_regex_add_contenteq_tests
Closed

test(regex): add ContentEq tests#6409
DonIsaac wants to merge 2 commits intomainfrom
don/10-09-test_regex_add_contenteq_tests

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 10, 2024

These files have no test coverage. This should help.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review October 10, 2024 00:27
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #6409 will not alter performance

Comparing don/10-09-test_regex_add_contenteq_tests (21b1dff) with main (384d5be)

Summary

✅ 29 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Oct 10, 2024

Nice catch, I found a better place to assert this, and we caught a few bugs already.

@DonIsaac
Copy link
Contributor Author

Closing in favor of #6411

@DonIsaac DonIsaac closed this Oct 10, 2024
@Boshen Boshen deleted the don/10-09-test_regex_add_contenteq_tests branch October 10, 2024 01:57
Boshen added a commit that referenced this pull request Oct 10, 2024
closes #6409

Marking as good first issue if anyone wants to pick this up and fix the failing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants