Integrate lint with oxc query by u9g · Pull Request #627 · oxc-project/oxc

u9g · 2023-07-26T05:56:38Z

No description provided.

u9g

some thoughts

crates/oxc_cli/src/lint/module_tree_handler.rs

crates/oxc_linter/Cargo.toml

u9g · 2023-07-26T06:00:18Z

crates/oxc_linter/examples/queries/next_google-font-display/display_has_bad_value.yml

+tests:
+  pass:
+    - relative_path:
+        - "index.tsx"


is it clear what this means and refers to?

u9g · 2023-07-26T06:00:39Z

crates/oxc_linter/examples/queries/next_google-font-display/display_has_bad_value.yml

+    - "block"
+    - "fallback"
+
+reason: "{display_value} is not recommended."


we do not have a way to plug stuff into these boxes yet

This would be nice maybe but I don't think it's important

crates/oxc_linter/examples/queries/next_inline-script-id/dangerouslySetInnerHTML.yml

crates/oxc_linter/src/plugin.rs

u9g · 2023-07-26T06:33:20Z

crates/oxc_linter/src/plugin.rs

+    use super::{LinterPlugin, SingleTest};
+    use crate::{LintContext, Linter};
+
+    #[test]


this needs to be exposed in cli too for user queries

We also should add snapshotting to the cli once this testing is added

The only reason to add snapshotting now is if the span would change for some reason. I think it's not really important considering the individual plugins are testable.

crates/oxc_wasm/src/lib.rs

u9g · 2023-08-17T14:08:23Z

crates/oxc_cli/src/plugin.rs

+                {
+                    println!("{v:#?}");
+                }
+                match (v.get("span_start"), v.get("span_end")) {


Is this too complex? What's a better way to do this?

u9g · 2023-08-17T14:14:43Z

crates/oxc_cli/src/plugin.rs

+            })
+            .take(usize::MAX)
+            {
+                ctx.with_rule_name(""); // leave this empty as it's a static string so we can't make it at runtime, and it's not userfacing


do we even need to call this?

u9g · 2023-08-17T14:16:10Z

crates/oxc_cli/src/plugin.rs

+fn span_of_test_n(query_text: &str, test_ix: usize) -> SourceSpan {
+    let yaml = YamlLoader::load_from_str(
+        // TODO: Should we just save the string after we read it originally?
+        query_text,


Should we just save the string after we read it originally? This a somewhat rare event so not sure if it's worth it to always store every rule's string value, rather than just reading one or a few twice.

u9g · 2023-08-18T01:45:55Z

crates/oxc_cli/examples/queries/next_no-duplicate-head/the_rule.yaml

@@ -0,0 +1,135 @@
+name: "next:no-duplicate-head:rule"


renamed to .yaml, which disables it, because:
the problem is this: In my tests infra, I assume that you only want to ever fail once, so I just throw an error during testing if you have more than one of any kind of error. the problem is that there are some tests that must throw multiple errors, so now we have a probelm

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | | | lockFileMaintenance | All locks refreshed | | [napi](https://togithub.com/napi-rs/napi-rs) | workspace.dependencies | patch | `2.16.4` -> `2.16.6` | | [napi-derive](https://togithub.com/napi-rs/napi-rs) | workspace.dependencies | patch | `2.16.3` -> `2.16.4` | | [num-bigint](https://togithub.com/rust-num/num-bigint) | workspace.dependencies | patch | `0.4.4` -> `0.4.5` | | [petgraph](https://togithub.com/petgraph/petgraph) | workspace.dependencies | patch | `0.6.4` -> `0.6.5` | | [proc-macro2](https://togithub.com/dtolnay/proc-macro2) | workspace.dependencies | patch | `1.0.81` -> `1.0.82` | | [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.200` -> `1.0.201` | | [serde_json](https://togithub.com/serde-rs/json) | workspace.dependencies | patch | `1.0.116` -> `1.0.117` | | [trybuild](https://togithub.com/dtolnay/trybuild) | workspace.dependencies | patch | `1.0.93` -> `1.0.95` | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>napi-rs/napi-rs (napi)</summary> ### [`v2.16.6`](https://togithub.com/napi-rs/napi-rs/releases/tag/napi%402.16.6) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/napi@2.16.5...napi@2.16.6) #### What's Changed - fix(napi): panic when deserializing empty buffer with Rust 1.78 by [@mischnic](https://togithub.com/mischnic) in [https://github.com/napi-rs/napi-rs/pull/2094](https://togithub.com/napi-rs/napi-rs/pull/2094) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.5...napi@2.16.6 ### [`v2.16.5`](https://togithub.com/napi-rs/napi-rs/releases/tag/napi%402.16.5) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/napi@2.16.4...napi@2.16.5) ##### What's Changed - Fix panic in JsArrayBufferValue as_ref/as_mut with Rust 1.78 by [@tronical](https://togithub.com/tronical) in [https://github.com/napi-rs/napi-rs/pull/2083](https://togithub.com/napi-rs/napi-rs/pull/2083) - fix(napi): make sure env without exception pending before throw error by [@southorange0929](https://togithub.com/southorange0929) in [https://github.com/napi-rs/napi-rs/pull/2092](https://togithub.com/napi-rs/napi-rs/pull/2092) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.16.4...napi@2.16.5 </details> <details> <summary>rust-num/num-bigint (num-bigint)</summary> ### [`v0.4.5`](https://togithub.com/rust-num/num-bigint/blob/HEAD/RELEASES.md#Release-045-2024-05-06) [Compare Source](https://togithub.com/rust-num/num-bigint/compare/num-bigint-0.4.4...num-bigint-0.4.5) - [Upgrade to 2021 edition, **MSRV 1.60**][292] - [Add `const ZERO` and implement `num_traits::ConstZero`][298] - [Add `modinv` methods for the modular inverse][288] - [Optimize multiplication with imbalanced operands][295] - [Optimize scalar division on x86 and x86-64][236] **Contributors**: [@cuviper](https://togithub.com/cuviper), [@joelonsql](https://togithub.com/joelonsql), [@waywardmonkeys](https://togithub.com/waywardmonkeys) [236]: https://togithub.com/rust-num/num-bigint/pull/236 [288]: https://togithub.com/rust-num/num-bigint/pull/288 [292]: https://togithub.com/rust-num/num-bigint/pull/292 [295]: https://togithub.com/rust-num/num-bigint/pull/295 [298]: https://togithub.com/rust-num/num-bigint/pull/298 </details> <details> <summary>petgraph/petgraph (petgraph)</summary> ### [`v0.6.5`](https://togithub.com/petgraph/petgraph/blob/HEAD/RELEASES.rst#Version-065-2024-05-06) [Compare Source](https://togithub.com/petgraph/petgraph/compare/petgraph@v0.6.4...petgraph@v0.6.5) \========================== - Add rayon support for `GraphMap` (`#573`*, `#615`*) - Add `Topo::with_initials` method (`#585`\_) - Add logo to the project (`#598`\_) - Add Ford-Fulkerson algorithm (`#640`\_) - Update `itertools` to 0.12.1 (`#628`\_) - Update `GraphMap` to allow custom hash functions (`#623`\_) - Fix documentation (`#630`\_) - Fix clippy warnings (`#627`\_) - (internal) Fix remove old `copyclone` macro (`#601`\_) - (internal) Move minimum spanning tree into own module (`#624`\_) .. \_`#573`: [https://github.com/petgraph/petgraph/pull/573](https://togithub.com/petgraph/petgraph/pull/573) .. \_`#615`: [https://github.com/petgraph/petgraph/pull/615](https://togithub.com/petgraph/petgraph/pull/615) .. \_`#585`: [https://github.com/petgraph/petgraph/pull/585](https://togithub.com/petgraph/petgraph/pull/585) .. \_`#598`: [https://github.com/petgraph/petgraph/pull/598](https://togithub.com/petgraph/petgraph/pull/598) .. \_`#640`: [https://github.com/petgraph/petgraph/pull/640](https://togithub.com/petgraph/petgraph/pull/640) .. \_`#628`: [https://github.com/petgraph/petgraph/pull/628](https://togithub.com/petgraph/petgraph/pull/628) .. \_`#623`: [https://github.com/petgraph/petgraph/pull/623](https://togithub.com/petgraph/petgraph/pull/623) .. \_`#630`: [https://github.com/petgraph/petgraph/pull/630](https://togithub.com/petgraph/petgraph/pull/630) .. \_`#627`: [https://github.com/petgraph/petgraph/pull/627](https://togithub.com/petgraph/petgraph/pull/627) .. \_`#601`: [https://github.com/petgraph/petgraph/pull/601](https://togithub.com/petgraph/petgraph/pull/601) .. \_`#624`: [https://github.com/petgraph/petgraph/pull/624](https://togithub.com/petgraph/petgraph/pull/624) </details> <details> <summary>dtolnay/proc-macro2 (proc-macro2)</summary> ### [`v1.0.82`](https://togithub.com/dtolnay/proc-macro2/releases/tag/1.0.82) [Compare Source](https://togithub.com/dtolnay/proc-macro2/compare/1.0.81...1.0.82) - Resolve unexpected_cfgs warning ([#456](https://togithub.com/dtolnay/proc-macro2/issues/456)) </details> <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.201`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.201) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.200...v1.0.201) - Resolve unexpected_cfgs warning ([#2737](https://togithub.com/serde-rs/serde/issues/2737)) </details> <details> <summary>serde-rs/json (serde_json)</summary> ### [`v1.0.117`](https://togithub.com/serde-rs/json/releases/tag/v1.0.117) [Compare Source](https://togithub.com/serde-rs/json/compare/v1.0.116...v1.0.117) - Resolve unexpected_cfgs warning ([#1130](https://togithub.com/serde-rs/json/issues/1130)) </details> <details> <summary>dtolnay/trybuild (trybuild)</summary> ### [`v1.0.95`](https://togithub.com/dtolnay/trybuild/releases/tag/1.0.95) [Compare Source](https://togithub.com/dtolnay/trybuild/compare/1.0.94...1.0.95) - Keep long type names in diagnostics so that test output does not vary depending on the length of the absolute filepath of the crate ([#269](https://togithub.com/dtolnay/trybuild/issues/269)) ### [`v1.0.94`](https://togithub.com/dtolnay/trybuild/releases/tag/1.0.94) [Compare Source](https://togithub.com/dtolnay/trybuild/compare/1.0.93...1.0.94) - Resolve unexpected_cfgs warning ([#268](https://togithub.com/dtolnay/trybuild/issues/268)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/oxc-project/oxc).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

github-actions bot added the A-linter Area - Linter label Jul 26, 2023

u9g commented Jul 26, 2023

View reviewed changes

u9g added 3 commits August 2, 2023 22:23

move example queries

3567403

add new deps to oxc_cli

3100a98

add linter plugin tests to oxc_cli

7065320

u9g force-pushed the integrate-lint-with-oxc-query branch from cd08884 to 7065320 Compare August 7, 2023 16:31

github-actions bot removed the A-linter Area - Linter label Aug 7, 2023

u9g added 17 commits August 7, 2023 12:37

elide braces if we don't need the fields

80e702e

don't abbreviate TRUSTFALL to TFALL

91e1608

match on outputted span_start and span_end

4a8e03e

Merge branch 'main' into integrate-lint-with-oxc-query

34327c9

fix span_start span_end handling

1e2ef16

fix tests

6d6f30c

Hook oxc_query upto the cli

66c4b5f

Get lintplugintestrunner almost working

3986948

Get test runner working

d46671b

clippy fix

c85437a

Make errors more idiomatic

bfc4fe9

add summary and fix reason for all example queries

e2f204e

remove todo

83fa35a

Add pretty errors

ecd11b4

remove clippy allows

ba3d2f3

return semantic erros too

c5970b2

arc twice

e1d4a5b

u9g commented Aug 17, 2023

View reviewed changes

u9g added 5 commits August 17, 2023 10:21

update dependencies

288a775

fix dependencies again

b7ef0a1

Merge branch 'main' into integrate-lint-with-oxc-query

55daf51

enable optimizations for trustfall_core and dependency of trustfall

9618fd9

Make LinterPlugin fallible

82a07a6

u9g added 12 commits August 17, 2023 13:20

actually give relative path parts

3cfeef9

propogate run_plugin_rules errors through in lint_path

302875c

show failing query for trustfall errors

af1762e

Simplify with_source_code condition

87c25fa

always throw errors on pass tests

6ccd0d7

add many more errors

75dd7f5

lint diagnostics

b2d6795

use expect over unwrap

4f45644

fix broken query

d06d4e4

fix err_span of tests

19cc40e

fix tests almost

dc5b8a8

rename test temporarily to disable it

22b16e7

u9g commented Aug 18, 2023

View reviewed changes

u9g added 5 commits August 17, 2023 23:42

add back failing test to error message

22694c5

make no-duplicate-head only match <Head /> after first one

0e065bb

fix query arguments

201c117

pass query path by reference

adddcc8

fix for previous commit

a159c5d

Boshen closed this Sep 10, 2023

Uh oh!

Conversation

u9g commented Jul 26, 2023

Uh oh!

u9g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

u9g Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

u9g Aug 17, 2023 •

edited

Loading