Skip to content

refactor(transformer): use AstBuilder instance from TraverseCtx#6173

Closed
shulaoda wants to merge 4 commits intooxc-project:mainfrom
shulaoda:refactor/transformer-transform-ctx
Closed

refactor(transformer): use AstBuilder instance from TraverseCtx#6173
shulaoda wants to merge 4 commits intooxc-project:mainfrom
shulaoda:refactor/transformer-transform-ctx

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Sep 30, 2024 •
edited
Loading

closes #6172

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler labels Sep 30, 2024
Boshen
Boshen reviewed Sep 30, 2024
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6173 will not alter performance

Comparing shulaoda:refactor/transformer-transform-ctx (e049c50) with main (f2ac584)

Summary

✅ 29 untouched benchmarks

Boshen
Boshen reviewed Sep 30, 2024
View reviewed changes
@shulaoda shulaoda force-pushed the refactor/transformer-transform-ctx branch from 3be28c0 to 9e7267d Compare September 30, 2024 04:24
@Dunqing Dunqing mentioned this pull request Sep 30, 2024
Merged
@graphite-app graphite-app bot closed this in f2ac584 Sep 30, 2024
@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 30, 2024

Could you reopen this PR? 😂 @Dunqing

@Boshen Boshen reopened this Sep 30, 2024
@shulaoda shulaoda force-pushed the refactor/transformer-transform-ctx branch from 9e7267d to 51a937a Compare September 30, 2024 06:44
@Dunqing
Copy link
Member

Dunqing commented Sep 30, 2024

Sorry, I tagged wrong

overlookmotel
overlookmotel reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@overlookmotel overlookmotel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this.

Apart from the comment above about reverting traverse_mut to how it was, looks great.

Please could make that change and ping me, so I can do a final review and merge it ASAP before we get merge conflicts?

@shulaoda shulaoda requested a review from overlookmotel October 1, 2024 01:54
@overlookmotel overlookmotel mentioned this pull request Oct 1, 2024
Merged
@overlookmotel
Copy link
Member

overlookmotel commented Oct 1, 2024

@shulaoda This has merge conflicts and I was worried that if I requested changes, there'd be more merge conflicts again by the time I got to reviewing your changes (probably we are in different time zones, and this PR touches a lot of files in the transformer, which is currently under heavy development).

So I have taken the liberty of rebasing this on latest main, fixing the problem discussed above, and merging it.

Sorry if it feels like I've taken over your work. I just really didn't want to waste your time going back-and-forwards endlessly dealing with merge conflicts. Really appreciate your work on this.

overlookmotel added a commit that referenced this pull request Oct 1, 2024
@overlookmotel
refactor(transformer): use AstBuilder instance from TraverseCtx (#6209)
235cdba 
A small modification of #6173. Closes #6172.
@overlookmotel overlookmotel mentioned this pull request Oct 1, 2024
Closed
@shulaoda shulaoda deleted the refactor/transformer-transform-ctx branch October 1, 2024 09:42
@7086cmd 7086cmd mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Boshen left review comments

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor transformer to use the instance of AstBuilder which is in TraverseCtx everywhere

4 participants

@shulaoda @Dunqing @overlookmotel @Boshen