Skip to content

refactor(transformer): move parsing pragmas into TS transform#6137

Merged
graphite-app[bot] merged 1 commit into
mainfrom
09-28-refactor_transformer_move_parsing_pragmas_into_ts_transform
Sep 28, 2024
Merged

refactor(transformer): move parsing pragmas into TS transform#6137
graphite-app[bot] merged 1 commit into
mainfrom
09-28-refactor_transformer_move_parsing_pragmas_into_ts_transform

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Sep 28, 2024

Copy link
Copy Markdown
Member

It's more natural for this code to live in TS transform.

@graphite-app

graphite-app Bot commented Sep 28, 2024

Copy link
Copy Markdown
Contributor

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

overlookmotel commented Sep 28, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added the A-transformer Area - Transformer / Transpiler label Sep 28, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 28, 2024 09:58
@codspeed-hq

codspeed-hq Bot commented Sep 28, 2024

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #6137 will not alter performance

Comparing 09-28-refactor_transformer_move_parsing_pragmas_into_ts_transform (0836f6b) with main (30424fa)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 28, 2024 — with Graphite App
@graphite-app

graphite-app Bot commented Sep 28, 2024

Copy link
Copy Markdown
Contributor

Merge activity

It's more natural for this code to live in TS transform.
@Boshen Boshen force-pushed the 09-28-refactor_transformer_move_parsing_pragmas_into_ts_transform branch from a9fd88a to 0836f6b Compare September 28, 2024 10:29
@graphite-app graphite-app Bot merged commit 0836f6b into main Sep 28, 2024
@graphite-app graphite-app Bot deleted the 09-28-refactor_transformer_move_parsing_pragmas_into_ts_transform branch September 28, 2024 10:33
Boshen added a commit that referenced this pull request Sep 29, 2024
## [0.30.5] - 2024-09-29

### Features

- 15552ac napi/transform: Display semantic error (#6160) (Boshen)
- f50fdcd napi/transform: Make react refresh option take a boolean
(#6146) (Boshen)

### Bug Fixes

- f27d59f napi/transform: Remove confusing `jsx` option (#6159) (Boshen)
- bfd1988 transformer/react: Should not collect use-hooks if it's a
nested member expression (#6143) (Dunqing)

### Refactor

- ab187d1 codegen: Restrict visibility of internal methods (#6145)
(DonIsaac)
- 375bebe transformer: Improve parsing React pragmas (#6138)
(overlookmotel)
- 0836f6b transformer: Move parsing pragmas into TS transform (#6137)
(overlookmotel)
- 30424fa transformer: TS transforms only store options they need
(#6135) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants