wip: feat(linter): add eslint/no-explicity-any#519
Closed
manuschillerdev wants to merge 6 commits intooxc-project:mainfrom
Closed
wip: feat(linter): add eslint/no-explicity-any#519manuschillerdev wants to merge 6 commits intooxc-project:mainfrom
manuschillerdev wants to merge 6 commits intooxc-project:mainfrom
Conversation
manuschillerdev
commented
Jul 5, 2023
manuschillerdev
commented
Jul 5, 2023
manuschillerdev
commented
Jul 5, 2023
|
|
||
| #[derive(Debug, Error, Diagnostic)] | ||
| #[error( | ||
| "typescript-eslint(no-explicit-any): Using any disables many type checking rules and is generally best used only as a last resort or when prototyping code" |
Author
There was a problem hiding this comment.
todo: check which labels/descriptions would be appropriate here
manuschillerdev
commented
Jul 5, 2023
| /// const ages: Array<any> = ['seventeen']; | ||
| /// ``` | ||
| NoExplicitAny, | ||
| correctness |
Author
There was a problem hiding this comment.
should probably be restriction instead:
DonIsaac
reviewed
Jul 6, 2023
| typescript::no_non_null_asserted_optional_chain, | ||
| typescript::no_unnecessary_type_constraint | ||
| typescript::no_unnecessary_type_constraint, | ||
| typescript::no_explicit_any |
Contributor
There was a problem hiding this comment.
nitpick: mind putting this in order alphabetically?
DonIsaac
reviewed
Jul 6, 2023
| #[error( | ||
| "typescript-eslint(no-explicit-any): Using any disables many type checking rules and is generally best used only as a last resort or when prototyping code" | ||
| )] | ||
| #[diagnostic(severity(warning))] |
|
|
Contributor
|
@manuschillerdev any plans to complete this PR? |
Closed
DonIsaac
added a commit
that referenced
this pull request
Sep 10, 2023
Implements `no-explicit-any` from `typescript-eslint`. Replaces #519 since it appears abandoned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the
no-explicit-anyrule for the typescript linter.