Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• feat(ast_codegen): add #[visit(enter_before)] hint. #4147 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #4147 will not alter performance

_{Comparing 07-09-fix_ast_ast_codegen_visit_decorators_in_class_before_node_events (3ba7cfe) with main (725571a)}

Summary

✅ 29 untouched benchmarks

Please see #4142 (comment). I'm not clear why this change is required.

Please see #4142 (comment). I'm not clear why this change is required.

I just saw your comment, Even with that it is a good thing to have the visit(enter_before) marker just in case we need it in the future. I can just remove the marker from Class and merge the generator code.

@Dunqing do you know about the semantic details here?

@Dunqing do you know about the semantic details here?

#4142 (comment)

I just saw your comment, Even with that it is a good thing to have the visit(enter_before) marker just in case we need it in the future. I can just remove the marker from Class and merge the generator code.

Yes, I think we can keep the visit(enter_before) marker for now. It may be useful for reimplementing the adding scope and resolving references.

Personally, I don't think we should ever enter the node late. It is just confusing, and I can't see a use case.

If you want to avoid throwing away the generator code you already wrote, by all means merge it in, but would you consider "deactivating" visit(enter_before), so we don't start using it kind of by accident without discussing first?

I'll generate an error on encountering it for now.

Merge activity

• Jul 10, 9:59 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 10, 10:01 AM EDT: rzvxa added this pull request to the Graphite merge queue.
• Jul 10, 10:06 AM EDT: rzvxa merged this pull request with the Graphite merge queue.