Skip to content

feat(semantic): add descendants iterator to the AstNodes.#3800

Closed
rzvxa wants to merge 1 commit intomainfrom
06-21-feat_semantic_add_descendants_iterator_to_the_astnodes_
Closed

feat(semantic): add descendants iterator to the AstNodes.#3800
rzvxa wants to merge 1 commit intomainfrom
06-21-feat_semantic_add_descendants_iterator_to_the_astnodes_

Conversation

@rzvxa
Copy link
Copy Markdown
Contributor

@rzvxa rzvxa commented Jun 21, 2024

Provides a way to walk down the AstNodes hierarchy, I need this to make sense of expressions when working with CFG, Our CFG works on the statement level so we need other parts of semantics to figure out the conditional expressions.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jun 21, 2024
Copy link
Copy Markdown
Contributor Author

rzvxa commented Jun 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 21, 2024

CodSpeed Performance Report

Merging #3800 will degrade performances by 30.67%

Comparing 06-21-feat_semantic_add_descendants_iterator_to_the_astnodes_ (e12d6ac) with main (f8fe583)

Summary

❌ 10 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 06-21-feat_semantic_add_descendants_iterator_to_the_astnodes_ Change
semantic[RadixUIAdoptionSection.jsx] 119 µs 171.7 µs -30.67%
semantic[antd.js] 202.6 ms 284 ms -28.68%
semantic[cal.com.tsx] 55.5 ms 76.9 ms -27.88%
semantic[checker.ts] 131.4 ms 174.9 ms -24.86%
semantic[pdf.mjs] 32 ms 45.9 ms -30.3%
transformer[RadixUIAdoptionSection.jsx] 248.4 µs 312.2 µs -20.44%
transformer[antd.js] 342.7 ms 472.2 ms -27.42%
transformer[cal.com.tsx] 84.9 ms 117.7 ms -27.85%
transformer[checker.ts] 207.1 ms 278 ms -25.51%
transformer[pdf.mjs] 54.2 ms 76.9 ms -29.52%

@Boshen
Copy link
Copy Markdown
Member

Boshen commented Jun 29, 2024

This is probably not what we want. Closing for house keeping.

@Boshen Boshen closed this Jun 29, 2024
@rzvxa rzvxa mentioned this pull request Aug 13, 2024
@Boshen Boshen deleted the 06-21-feat_semantic_add_descendants_iterator_to_the_astnodes_ branch September 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants