Skip to content

feat(tasks/coverage): use the classic runtime to rerun the transformer#3484

Closed
Dunqing wants to merge 2 commits intomainfrom
05-31-feat_tasks_coverage_use_the_classic_runtime_to_rerun_the_transformer
Closed

feat(tasks/coverage): use the classic runtime to rerun the transformer#3484
Dunqing wants to merge 2 commits intomainfrom
05-31-feat_tasks_coverage_use_the_classic_runtime_to_rerun_the_transformer

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented May 31, 2024

No description provided.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented May 31, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Copy Markdown
Member Author

Dunqing commented May 31, 2024

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #3484 will not alter performance

Comparing 05-31-feat_tasks_coverage_use_the_classic_runtime_to_rerun_the_transformer (926634f) with 05-31-refactor_transformer_typescript_use_a_memory-safe_implementation_instead (6ea2bb2)

Summary

✅ 22 untouched benchmarks

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented May 31, 2024

Merge activity

  • May 31, 7:15 AM EDT: Dunqing added this pull request to the Graphite merge queue.
  • May 31, 7:22 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@Dunqing Dunqing force-pushed the 05-31-refactor_transformer_typescript_use_a_memory-safe_implementation_instead branch from 6ea2bb2 to 9dc58d5 Compare May 31, 2024 11:15
@Dunqing Dunqing changed the base branch from 05-31-refactor_transformer_typescript_use_a_memory-safe_implementation_instead to main May 31, 2024 11:20
Copy link
Copy Markdown
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird, let me double check

@Dunqing Dunqing closed this Jun 11, 2024
@Boshen Boshen deleted the 05-31-feat_tasks_coverage_use_the_classic_runtime_to_rerun_the_transformer branch September 11, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants