• fix(ast): add RestElements in serialized AST to elements array #2567
• fix(ast): rename serialized fields to camel case #2566 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

@ArnaudBarre Was there a reason why you didn't do these already in #2522?

(trailing_comma in ArrayExpression, ObjectExpression and
ArrayAssignmentTarget)

CodSpeed Performance Report

Merging #2566 will not alter performance

_{Comparing 03-02-fix_ast_rename_serialized_fields_to_camel_case (c75a78e) with main (78f8c2c)}

Summary

✅ 27 untouched benchmarks

I didn't include this one because I think tailing comma part of ESTree and I let discussing skip vs camelCase for later

Ah I see. Well maybe they should be skipped. But regardless of whether they're in ESTree or not, I think it's better all properties in JSON AST are camelCase - snake_case would be unexpected to JS users.

Yeah this could be added to all nodes for potential future field if the cost is 0, if there is a small cost I think this is fine adding it when needed

I don't think there's any runtime cost to field renaming, as the serializers are built at compile-time. Maybe yes we should add to all AST structs.