perf(linter/eslint/no-useless-call): fast-path static callees#24077
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and optimizes the eslint/no-useless-call lint rule’s hot path by adding a direct classifier for common static-member callees (foo.call(...) / foo.apply(...)) while preserving the existing fallback for more complex callee shapes (parenthesized, chained/optional, computed).
Changes:
- Introduce
classify_callee+CallOrApplyto quickly recognize.call/.applyonExpression::StaticMemberExpressionbefore the more general member-expression handling. - Consolidate argument-shape validation into
CallOrApply::has_valid_argumentsand simplify the mainrunflow. - Add regression coverage for parenthesized callee forms like
(foo.call)(...)/(obj.foo.apply)(...)and update the corresponding insta snapshot.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_linter/src/rules/eslint/no_useless_call.rs | Adds a fast callee classifier for .call/.apply and refactors argument gating to reduce work on non-matching calls. |
| crates/oxc_linter/src/snapshots/eslint_no_useless_call.snap | Updates snapshots to reflect newly-covered parenthesized .call / .apply failure cases. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
Merge activity
|
## Summary - Split the `eslint/no-useless-call` fast path out from #23829 for easier review and bisectability. - Add a direct static-member callee classifier for `foo.call(...)` / `foo.apply(...)`, so common non-`.call` / non-`.apply` static calls return before the generic member-expression fallback. - Keep the fallback for parenthesized, chained, computed, and optional-chain cases, with parenthesized regression coverage. Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
6e7b8ff to
fdbd34d
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
## Summary - Split the `eslint/no-useless-call` fast path out from #23829 for easier review and bisectability. - Add a direct static-member callee classifier for `foo.call(...)` / `foo.apply(...)`, so common non-`.call` / non-`.apply` static calls return before the generic member-expression fallback. - Keep the fallback for parenthesized, chained, computed, and optional-chain cases, with parenthesized regression coverage. Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
## Summary - Split the `eslint/no-useless-call` fast path out from #23829 for easier review and bisectability. - Add a direct static-member callee classifier for `foo.call(...)` / `foo.apply(...)`, so common non-`.call` / non-`.apply` static calls return before the generic member-expression fallback. - Keep the fallback for parenthesized, chained, computed, and optional-chain cases, with parenthesized regression coverage. Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint/no-useless-callfast path out from perf(linter): speed up hot rules on large codebases #23829 for easier review and bisectability.foo.call(...)/foo.apply(...), so common non-.call/ non-.applystatic calls return before the generic member-expression fallback.Credit to Yagiz Nizipli for the original work in #23829.
Co-authored-by: Yagiz Nizipli yagiz@nizipli.com