perf(linter/eslint/no-obj-calls): use direct global matches#24076
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the hot-path performance of the eslint/no-obj-calls linter rule by reducing per-node overhead in common non-reporting cases, aligning with Oxc’s focus on minimizing work when most files produce no diagnostics.
Changes:
- Replaced a small
NON_CALLABLE_GLOBALS.contains(..)lookup with a directmatches!(..)check for faster global-name matching. - Deferred
scoping()/nodes()access and binding-resolution work until after confirming the identifier is not a direct global reference.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
## Summary - replace the small non-callable global list lookup with a direct `matches!` helper - defer `resolve_global_binding` scoping/node setup until after its existing global-reference check Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
55f9c85 to
4781b2d
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
## Summary - replace the small non-callable global list lookup with a direct `matches!` helper - defer `resolve_global_binding` scoping/node setup until after its existing global-reference check Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
## Summary - replace the small non-callable global list lookup with a direct `matches!` helper - defer `resolve_global_binding` scoping/node setup until after its existing global-reference check Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matches!helperresolve_global_bindingscoping/node setup until after its existing global-reference checkCredit to Yagiz Nizipli for the original work in #23829.
Co-authored-by: Yagiz Nizipli yagiz@nizipli.com