perf(linter/import/extensions): skip empty config and borrow extensions#24075
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the import/extensions linter rule hot path by avoiding unnecessary work when the rule has no effective configuration, and by reducing allocations when parsing written extensions.
Changes:
- Add an early return in
process_importwhen config is effectively empty/default (no rules to enforce). - Change written-extension parsing to return
Cow<str>so lowercase extensions can stay borrowed instead of allocating. - Minor refactor of query-string stripping in extension parsing (
split_once('?')).
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
…ns (#24075) ## Summary - split out the remaining safe `import/extensions` performance slice from #23829 for easier review and bisectability - skip the rule work early when the config is effectively empty/default and there is nothing to enforce - parse written extensions as `Cow<str>` so common lowercase specifiers stay borrowed - preserve the existing written-extension behavior for cases like written `.js` resolving to `.ts` Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
d969992 to
b1be114
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
…ns (#24075) ## Summary - split out the remaining safe `import/extensions` performance slice from #23829 for easier review and bisectability - skip the rule work early when the config is effectively empty/default and there is nothing to enforce - parse written extensions as `Cow<str>` so common lowercase specifiers stay borrowed - preserve the existing written-extension behavior for cases like written `.js` resolving to `.ts` Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
…ns (#24075) ## Summary - split out the remaining safe `import/extensions` performance slice from #23829 for easier review and bisectability - skip the rule work early when the config is effectively empty/default and there is nothing to enforce - parse written extensions as `Cow<str>` so common lowercase specifiers stay borrowed - preserve the existing written-extension behavior for cases like written `.js` resolving to `.ts` Credit to Yagiz Nizipli for the original work in #23829. Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import/extensionsperformance slice from perf(linter): speed up hot rules on large codebases #23829 for easier review and bisectabilityCow<str>so common lowercase specifiers stay borrowed.jsresolving to.tsCredit to Yagiz Nizipli for the original work in #23829.
Co-authored-by: Yagiz Nizipli yagiz@nizipli.com