Skip to content

feat(formatter_css): update oxc-css-parser@0.0.3#23974

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-30-feat_formatter_css_partial_support_postcss-simple-vars
Jul 1, 2026
Merged

feat(formatter_css): update oxc-css-parser@0.0.3#23974
graphite-app[bot] merged 1 commit into
mainfrom
06-30-feat_formatter_css_partial_support_postcss-simple-vars

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #23969, closes #23983.

Notably oxc-css-parser@0.0.3 contains:

  • partial postcss-simple-vars support
  • fix glued css-in-js placeholder (${C}:hover &)

As oxc_allocator has also been added as a dependency in oxc-css-parser, this has caused a conflict with the latest local (workspace) instance, so a patch.crates-io section has also been added. Apparently, this is a technique also used in Tokio.

@leaysgur Graphite App

leaysgur commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-formatter Area - Formatter label Jun 30, 2026
@leaysgur leaysgur force-pushed the 06-30-feat_formatter_css_partial_support_postcss-simple-vars branch from 05a80f3 to 8b48e8b Compare July 1, 2026 01:42
@leaysgur leaysgur changed the title feat(formatter_css): partial support postcss-simple-vars feat(formatter_css): update oxc-css-parser@0.0.3 Jul 1, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing 06-30-feat_formatter_css_partial_support_postcss-simple-vars (95c36bd) with main (0d34b00)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a7a4dfa) during the generation of this report, so 0d34b00 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@leaysgur leaysgur force-pushed the 06-30-feat_formatter_css_partial_support_postcss-simple-vars branch 2 times, most recently from 2fb9197 to 95c36bd Compare July 1, 2026 01:54
@leaysgur leaysgur marked this pull request as ready for review July 1, 2026 01:54
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2026
@leaysgur Graphite App

leaysgur commented Jul 1, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • Jul 1, 1:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 2:15 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 2:15 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Jul 1, 2:21 AM UTC: Merged by the Graphite merge queue.

@leaysgur leaysgur added run-oxfmt-ecosystem-ci and removed 0-merge Merge with Graphite Merge Queue labels Jul 1, 2026
@oxc-guard

oxc-guard Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oxfmt Ecosystem CI

suite oxfmt@latest refs/pull/23974/head branch
monkeytypegame/monkeytype ❌ ✅
cnpm/cnpmcore ❌ ✅
actualbudget/actual ❌ ✅
eggjs/egg ❌ ✅
dyad-sh/dyad ✅ ✅
vercel/turborepo ✅ ✅
lichess-org/lila ❌ ✅
vuejs/pinia ❌ ✅
tale/headplane ❌ ✅
aidenybai/react-grab ❌ ✅
huggingface/huggingface.js ✅ ✅
fastify/fastify-vite ✅ ✅
mastodon/mastodon ✅ ✅
getsentry/sentry-javascript ❌ ✅
AmanVarshney01/create-better-t-stack ✅ ✅
fuma-nama/fumadocs ✅ ✅
formatjs/formatjs ❌ ✅
cloudflare/agents ✅ ✅
vuejs/core ✅ ✅
openclaw/openclaw ❌ ✅
cloudflare/workers-sdk ❌ ✅
mantinedev/mantine ✅ ❌
Comfy-Org/ComfyUI_frontend ⚠️ ✅
npmx-dev/npmx.dev ✅ ✅
rolldown/rolldown ✅ ✅

💥 = panic, ⚠️ = error e.g. parse error (branch column: only new errors), ❌ = diff or exit code mismatch

@leaysgur

leaysgur commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

The diffs in mantine relate to an issue with the display of CI results; in fact, the formatting has actually been improved.
See the detailed log: https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/28488160351/job/84439435366

Will be fixed by oxc-project/oxc-ecosystem-ci#230

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2026
@leaysgur
feat(formatter_css): update oxc-css-parser@0.0.3 (#23974)
e0b35a1 
Fixes #23969, closes #23983.

Notably `oxc-css-parser@0.0.3` contains:

- partial `postcss-simple-vars` support
- fix glued css-in-js placeholder (`${C}:hover &`)

As `oxc_allocator` has also been added as a dependency in `oxc-css-parser`, this has caused a conflict with the latest local (workspace) instance, so a `patch.crates-io` section has also been added. Apparently, this is a technique also used in [Tokio](https://github.com/tokio-rs/tokio/blob/master/Cargo.toml#L18-L23).
@graphite-app graphite-app Bot force-pushed the 06-30-feat_formatter_css_partial_support_postcss-simple-vars branch from 95c36bd to e0b35a1 Compare July 1, 2026 02:17
@graphite-app graphite-app Bot merged commit e0b35a1 into main Jul 1, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2026
@graphite-app graphite-app Bot deleted the 06-30-feat_formatter_css_partial_support_postcss-simple-vars branch July 1, 2026 02:21
@leaysgur leaysgur mentioned this pull request Jul 1, 2026
Closed
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@leaysgur @camc314
feat(formatter_css): update oxc-css-parser@0.0.3 (#23974)
144746a 
Fixes #23969, closes #23983.

Notably `oxc-css-parser@0.0.3` contains:

- partial `postcss-simple-vars` support
- fix glued css-in-js placeholder (`${C}:hover &`)

As `oxc_allocator` has also been added as a dependency in `oxc-css-parser`, this has caused a conflict with the latest local (workspace) instance, so a `patch.crates-io` section has also been added. Apparently, this is a technique also used in [Tokio](https://github.com/tokio-rs/tokio/blob/master/Cargo.toml#L18-L23).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatter_css: Support PostCSS plugin syntax?

1 participant

@leaysgur