Skip to content

fix(tasks): enable disable_old_builder Cargo feature for oxc_ast crate for all tasks#23885

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-28-fix_tasks_enable_disable_old_builder_cargo_feature_for_oxc_ast_crate_for_all_tasks
Jun 28, 2026
Merged

fix(tasks): enable disable_old_builder Cargo feature for oxc_ast crate for all tasks#23885
graphite-app[bot] merged 1 commit into
mainfrom
om/06-28-fix_tasks_enable_disable_old_builder_cargo_feature_for_oxc_ast_crate_for_all_tasks

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #23043.

We don't enable oxc_ast's disable_old_builder Cargo feature in any of our published crates, or crates that are depended on by published crates.

Tasks are private to the repo, so enable this feature on them, to ensure no usage of legacy AstBuilder methods sneak in during the transition period before we delete these methods.

@overlookmotel Graphite App

overlookmotel commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 28, 2026
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added A-transformer Area - Transformer / Transpiler A-formatter Area - Formatter labels Jun 28, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-28-fix_tasks_enable_disable_old_builder_cargo_feature_for_oxc_ast_crate_for_all_tasks (85a6853) with main (daeed09)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (85a6853) during the generation of this report, so daeed09 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel marked this pull request as ready for review June 28, 2026 12:04
@overlookmotel overlookmotel requested a review from Dunqing as a code owner June 28, 2026 12:04
Copilot AI review requested due to automatic review settings June 28, 2026 12:04
Copilot AI reviewed Jun 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overlookmotel overlookmotel self-assigned this Jun 28, 2026
@graphite-app

graphite-app Bot commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
fix(tasks): enable disable_old_builder Cargo feature for oxc_ast …
85a6853 
…crate for all tasks (#23885)

Part of #23043.

We don't enable `oxc_ast`'s `disable_old_builder` Cargo feature in any of our published crates, or crates that are depended on by published crates.

Tasks are private to the repo, so enable this feature on them, to ensure no usage of legacy `AstBuilder` methods sneak in during the transition period before we delete these methods.
@graphite-app graphite-app Bot force-pushed the om/06-28-fix_tasks_enable_disable_old_builder_cargo_feature_for_oxc_ast_crate_for_all_tasks branch from 3ca101b to 85a6853 Compare June 28, 2026 12:13
@graphite-app graphite-app Bot merged commit 85a6853 into main Jun 28, 2026
39 checks passed
@graphite-app graphite-app Bot deleted the om/06-28-fix_tasks_enable_disable_old_builder_cargo_feature_for_oxc_ast_crate_for_all_tasks branch June 28, 2026 12:17
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
fix(tasks): enable disable_old_builder Cargo feature for oxc_ast …
86db305 
…crate for all tasks (#23885)

Part of #23043.

We don't enable `oxc_ast`'s `disable_old_builder` Cargo feature in any of our published crates, or crates that are depended on by published crates.

Tasks are private to the repo, so enable this feature on them, to ensure no usage of legacy `AstBuilder` methods sneak in during the transition period before we delete these methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner
@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner
@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-formatter Area - Formatter A-transformer Area - Transformer / Transpiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel