Skip to content

refactor(ast): hide allocator field of new AstBuilder#23874

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-27-refactor_ast_hide_allocator_field_of_new_astbuilder_
Jun 27, 2026
Merged

refactor(ast): hide allocator field of new AstBuilder#23874
graphite-app[bot] merged 1 commit into
mainfrom
om/06-27-refactor_ast_hide_allocator_field_of_new_astbuilder_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #23043.

Do not expose allocator field of new AstBuilder. It's available via allocator method provided by GetAllocator trait.

This gives us more flexibility in future.

@overlookmotel Graphite App

overlookmotel commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 27, 2026
Merged
Merged
@github-actions github-actions Bot added A-parser Area - Parser A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-isolated-declarations Isolated Declarations labels Jun 27, 2026
@overlookmotel overlookmotel marked this pull request as ready for review June 27, 2026 19:23
@overlookmotel overlookmotel requested a review from Dunqing as a code owner June 27, 2026 19:23
Copilot AI review requested due to automatic review settings June 27, 2026 19:23
Copilot AI reviewed Jun 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codspeed-hq

codspeed-hq Bot commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-27-refactor_ast_hide_allocator_field_of_new_astbuilder_ (83b64d8) with main (7136182)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (83b64d8) during the generation of this report, so 7136182 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel self-assigned this Jun 27, 2026
@overlookmotel overlookmotel mentioned this pull request Jun 27, 2026
Merged
@graphite-app

graphite-app Bot commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
refactor(ast): hide allocator field of new AstBuilder (#23874)
83b64d8 
Part of #23043.

Do not expose `allocator` field of new `AstBuilder`. It's available via `allocator` method provided by `GetAllocator` trait.

This gives us more flexibility in future.
@graphite-app graphite-app Bot force-pushed the om/06-27-refactor_ast_hide_allocator_field_of_new_astbuilder_ branch from 09ecc2f to 83b64d8 Compare June 27, 2026 20:37
@graphite-app graphite-app Bot merged commit 83b64d8 into main Jun 27, 2026
39 checks passed
@graphite-app graphite-app Bot deleted the om/06-27-refactor_ast_hide_allocator_field_of_new_astbuilder_ branch June 27, 2026 20:42
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
refactor(ast): hide allocator field of new AstBuilder (#23874)
fd556b4 
Part of #23043.

Do not expose `allocator` field of new `AstBuilder`. It's available via `allocator` method provided by `GetAllocator` trait.

This gives us more flexibility in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-ast Area - AST A-isolated-declarations Isolated Declarations A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel