Skip to content

refactor(linter/react/no-array-index-key): remove unused argument#23855

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/refactor-no-array-index-key-prop-name
Jun 26, 2026
Merged

refactor(linter/react/no-array-index-key): remove unused argument#23855
graphite-app[bot] merged 1 commit into
mainfrom
codex/refactor-no-array-index-key-prop-name

Conversation

@camc314

@camc314 camc314 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the A-linter Area - Linter label Jun 26, 2026
@camc314 camc314 self-assigned this Jun 26, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 26, 2026

camc314 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

…3855)

Removes the unused `prop_name` argument and inlines its sole `"key"` value.

**Stack**
 - #23857
 - #23856
 - #23855 👈 this PR!
@graphite-app graphite-app Bot force-pushed the codex/refactor-no-array-index-key-prop-name branch from 2d3155b to bc2b128 Compare June 26, 2026 20:37
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing codex/refactor-no-array-index-key-prop-name (2d3155b) with main (94b6599)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app Bot merged commit bc2b128 into main Jun 26, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 26, 2026
@graphite-app graphite-app Bot deleted the codex/refactor-no-array-index-key-prop-name branch June 26, 2026 20:41
graphite-app Bot pushed a commit that referenced this pull request Jun 26, 2026
#23856)

- Split from #23829.
- Replace separate second- and third-index method arrays with a direct `match` that selects the callback index argument position.

**Stack**
 - #23857
 - #23856 👈 this PR!
 - #23855

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
graphite-app Bot pushed a commit that referenced this pull request Jun 26, 2026
)

Split from #23829.

Delay `find_index_param_symbol_id` until after finding a relevant JSX `key` attribute or `React.cloneElement` key property.

Use lazy, peekable iterators so the symbol lookup runs once only when needed while still checking every matching key. Add regression coverage for duplicate JSX attributes and object properties.

**Stack**
 - #23857 👈 this PR!
 - #23856
 - #23855

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314 added a commit that referenced this pull request Jul 3, 2026
…3855)

Removes the unused `prop_name` argument and inlines its sole `"key"` value.

**Stack**
 - #23857
 - #23856
 - #23855 👈 this PR!
camc314 added a commit that referenced this pull request Jul 3, 2026
#23856)

- Split from #23829.
- Replace separate second- and third-index method arrays with a direct `match` that selects the callback index argument position.

**Stack**
 - #23857
 - #23856 👈 this PR!
 - #23855

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314 added a commit that referenced this pull request Jul 3, 2026
)

Split from #23829.

Delay `find_index_param_symbol_id` until after finding a relevant JSX `key` attribute or `React.cloneElement` key property.

Use lazy, peekable iterators so the symbol lookup runs once only when needed while still checking every matching key. Add regression coverage for duplicate JSX attributes and object properties.

**Stack**
 - #23857 👈 this PR!
 - #23856
 - #23855

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant