refactor(linter/react/no-array-index-key): remove unused argument#23855
Merged
graphite-app[bot] merged 1 commit intoJun 26, 2026
Merged
Conversation
Contributor
Author
Merge activity
|
2d3155b to
bc2b128
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 26, 2026
) Split from #23829. Delay `find_index_param_symbol_id` until after finding a relevant JSX `key` attribute or `React.cloneElement` key property. Use lazy, peekable iterators so the symbol lookup runs once only when needed while still checking every matching key. Add regression coverage for duplicate JSX attributes and object properties. **Stack** - #23857 👈 this PR! - #23856 - #23855 Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
) Split from #23829. Delay `find_index_param_symbol_id` until after finding a relevant JSX `key` attribute or `React.cloneElement` key property. Use lazy, peekable iterators so the symbol lookup runs once only when needed while still checking every matching key. Add regression coverage for duplicate JSX attributes and object properties. **Stack** - #23857 👈 this PR! - #23856 - #23855 Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
prop_nameargument and inlines its sole"key"value.Stack