Skip to content

refactor(linter): migrate to new AstBuilder#23782

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/migrate-linter-new-ast-builder
Jun 25, 2026
Merged

refactor(linter): migrate to new AstBuilder#23782
graphite-app[bot] merged 1 commit into
mainfrom
c/migrate-linter-new-ast-builder

Conversation

@camc314

@camc314 camc314 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I created this ontop of #23781 just to avoid any potential conflicts.

Follows on from #23730

It was relatively pain free! Thanks @ overlookmotel for the migration script!

@camc314 camc314 changed the base branch from main to om/06-25-feat_str_str_and_ident_methods_take_getallocator_ June 25, 2026 11:31
@github-actions github-actions Bot added the A-linter Area - Linter label Jun 25, 2026
@camc314 camc314 changed the title refactor(linter): migrate to new ast builder refactor(linter): migrate to new AstBuilder Jun 25, 2026
@camc314 camc314 marked this pull request as ready for review June 25, 2026 11:33
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1

Comparing c/migrate-linter-new-ast-builder (eac004c) with main (025045d)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel force-pushed the om/06-25-feat_str_str_and_ident_methods_take_getallocator_ branch from 2587c64 to 2c7d355 Compare June 25, 2026 11:42
@graphite-app graphite-app Bot force-pushed the om/06-25-feat_str_str_and_ident_methods_take_getallocator_ branch from 2c7d355 to 88f4455 Compare June 25, 2026 12:00
Base automatically changed from om/06-25-feat_str_str_and_ident_methods_take_getallocator_ to main June 25, 2026 12:04
@camc314 camc314 force-pushed the c/migrate-linter-new-ast-builder branch from 85a38ac to c92d1ba Compare June 25, 2026 12:53
This was referenced Jun 25, 2026
Merged
Merged
overlookmotel
overlookmotel reviewed Jun 25, 2026
View reviewed changes
Comment thread crates/oxc_linter/src/rules/react/exhaustive_deps.rs Outdated
Comment thread crates/oxc_linter/src/utils/react.rs Outdated
Comment thread crates/oxc_linter/src/utils/react.rs Outdated
@overlookmotel

overlookmotel commented Jun 25, 2026

Copy link
Copy Markdown
Member

Looks good! Thanks for doing this.

I pushed 3 small commits to shorten code in a few places. Will merge assuming I didn't screw up and CI passes.

@overlookmotel overlookmotel self-assigned this Jun 25, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2026
@camc314 Graphite App

camc314 commented Jun 25, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

@camc314
refactor(linter): migrate to new AstBuilder (#23782)
222e9f6 
I created this ontop of #23781 just to avoid any potential conflicts.

Follows on from #23730

It was relatively pain free! Thanks @ overlookmotel for the migration script!
@graphite-app graphite-app Bot force-pushed the c/migrate-linter-new-ast-builder branch from eac004c to 222e9f6 Compare June 25, 2026 16:55
@graphite-app graphite-app Bot merged commit 222e9f6 into main Jun 25, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2026
@graphite-app graphite-app Bot deleted the c/migrate-linter-new-ast-builder branch June 25, 2026 16:59
graphite-app Bot pushed a commit that referenced this pull request Jun 26, 2026
@camc314
feat(codegen): expose Codegen::print_string API (#23785)
cd1fd12 
## Summary

- expose `Codegen::print_string` for printing an escaped JavaScript string literal from `&str`
- share the existing string escaping implementation without constructing an AST
- disallow template literal output so the API is safe in string-literal-only contexts
- add coverage for quote selection, escaping, Unicode, and minified output

Part of #23780.

**Stack:**
 - #23786
 - #23785 (this PR)
 - #23782
graphite-app Bot pushed a commit that referenced this pull request Jun 26, 2026
@camc314
refactor(linter): print strings without constructing ASTs (#23786)
7c7ce24 
## Summary

- replace seven synthetic string literal AST constructions with `Codegen::print_string`
- remove the associated temporary allocators, AST builders, and unused imports
- preserve existing fixer options and generated output

Closes #23780.

**Stack:**
 - #23786 (this PR)
 - #23785
 - #23782
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
refactor(linter): migrate to new AstBuilder (#23782)
516832a 
I created this ontop of #23781 just to avoid any potential conflicts.

Follows on from #23730

It was relatively pain free! Thanks @ overlookmotel for the migration script!
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
feat(codegen): expose Codegen::print_string API (#23785)
cd9883b 
## Summary

- expose `Codegen::print_string` for printing an escaped JavaScript string literal from `&str`
- share the existing string escaping implementation without constructing an AST
- disallow template literal output so the API is safe in string-literal-only contexts
- add coverage for quote selection, escaping, Unicode, and minified output

Part of #23780.

**Stack:**
 - #23786
 - #23785 (this PR)
 - #23782
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
refactor(linter): print strings without constructing ASTs (#23786)
0517557 
## Summary

- replace seven synthetic string literal AST constructions with `Codegen::print_string`
- remove the associated temporary allocators, AST builders, and unused imports
- preserve existing fixer options and generated output

Closes #23780.

**Stack:**
 - #23786 (this PR)
 - #23785
 - #23782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel left review comments
@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees

@overlookmotel overlookmotel

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314 @overlookmotel