Skip to content

refactor(ast): AstBuilder::vec1 use Vec::from_value_in#23719

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_
Jun 22, 2026
Merged

refactor(ast): AstBuilder::vec1 use Vec::from_value_in#23719
graphite-app[bot] merged 1 commit into
mainfrom
om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

AstBuilder::vec1 use Vec::from_value_in (introduced in #23718).

This was referenced Jun 22, 2026
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Jun 22, 2026
Merged
@github-actions github-actions Bot added the A-ast Area - AST label Jun 22, 2026
@overlookmotel overlookmotel marked this pull request as ready for review June 22, 2026 14:41
Copilot AI review requested due to automatic review settings June 22, 2026 14:41
@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_ (0057ec6) with main (cf5e47e)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (0057ec6) during the generation of this report, so cf5e47e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot AI reviewed Jun 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors AstBuilder::vec1 in oxc_ast to use the new allocator-level helper Vec::from_value_in, aligning AST construction utilities with the allocator crate’s single-element Vec API.

Changes:

  • Replaced AstBuilder::vec1 implementation from vec_from_array([value]) to Vec::from_value_in(value, self.allocator).

@overlookmotel overlookmotel self-assigned this Jun 22, 2026
@overlookmotel overlookmotel force-pushed the om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_ branch from a7dc194 to 3ba476f Compare June 22, 2026 14:52
@overlookmotel overlookmotel force-pushed the om/06-22-feat_allocator_add_vec_from_value_in_method branch from b7e49ff to dafa5a7 Compare June 22, 2026 14:52
@graphite-app

graphite-app Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
refactor(ast): AstBuilder::vec1 use Vec::from_value_in (#23719)
0057ec6 
`AstBuilder::vec1` use `Vec::from_value_in` (introduced in #23718).
@graphite-app graphite-app Bot force-pushed the om/06-22-feat_allocator_add_vec_from_value_in_method branch from dafa5a7 to fcbf993 Compare June 22, 2026 15:03
@graphite-app graphite-app Bot force-pushed the om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_ branch from 3ba476f to 0057ec6 Compare June 22, 2026 15:03
Base automatically changed from om/06-22-feat_allocator_add_vec_from_value_in_method to main June 22, 2026 15:08
@graphite-app graphite-app Bot merged commit 0057ec6 into main Jun 22, 2026
40 checks passed
@graphite-app graphite-app Bot deleted the om/06-22-refactor_ast_astbuilder_vec1_use_vec_from_value_in_ branch June 22, 2026 15:09
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
refactor(ast): AstBuilder::vec1 use Vec::from_value_in (#23719)
d80b5bb 
`AstBuilder::vec1` use `Vec::from_value_in` (introduced in #23718).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-ast Area - AST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel