Skip to content

refactor(formatter_core): unify arena_cow_str usage#23700

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-22-refactor_formatter_core_unify_arena_cow_str_usage
Jun 22, 2026
Merged

refactor(formatter_core): unify arena_cow_str usage#23700
graphite-app[bot] merged 1 commit into
mainfrom
06-22-refactor_formatter_core_unify_arena_cow_str_usage

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #23528.
(I will confirm this (should be lived in oxc_allocator side?) later, then refactor all callsites)

@leaysgur Graphite App

leaysgur commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 22, 2026
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added the A-formatter Area - Formatter label Jun 22, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing 06-22-refactor_formatter_core_unify_arena_cow_str_usage (44e4c6c) with main (a36e444)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (b27c19e) during the generation of this report, so a36e444 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@leaysgur leaysgur force-pushed the 06-22-refactor_formatter_core_unify_arena_cow_str_usage branch from 5e222d6 to 528fc69 Compare June 22, 2026 05:13
@leaysgur leaysgur changed the title refactor(formatter_core): unify arena_cow_str usage refactor(formatter_core): unify arena_cow_str usage Jun 22, 2026
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 22, 2026
@graphite-app

graphite-app Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@graphite-app graphite-app Bot changed the base branch from 06-22-chore_formatter_fix_.gitattributes_pattern_for_clrf_fixtures to graphite-base/23700 June 22, 2026 05:16
@graphite-app graphite-app Bot changed the base branch from graphite-base/23700 to main June 22, 2026 05:24
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 22, 2026
@leaysgur
refactor(formatter_core): unify arena_cow_str usage (#23700)
44e4c6c 
Closes #23528.
(I will confirm this (should be lived in `oxc_allocator` side?) later, then refactor all callsites)
@graphite-app graphite-app Bot force-pushed the 06-22-refactor_formatter_core_unify_arena_cow_str_usage branch from 528fc69 to 44e4c6c Compare June 22, 2026 05:24
@graphite-app graphite-app Bot merged commit 44e4c6c into main Jun 22, 2026
37 checks passed
@graphite-app graphite-app Bot deleted the 06-22-refactor_formatter_core_unify_arena_cow_str_usage branch June 22, 2026 05:30
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@leaysgur @camc314
refactor(formatter_core): unify arena_cow_str usage (#23700)
50940ce 
Closes #23528.
(I will confirm this (should be lived in `oxc_allocator` side?) later, then refactor all callsites)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur