Skip to content

refactor(linter): remove number_as_object_schema helper#23614

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-18-refactor_linter_remove_number_as_object_schema_helper
Jun 20, 2026
Merged

refactor(linter): remove number_as_object_schema helper#23614
graphite-app[bot] merged 1 commit into
mainfrom
06-18-refactor_linter_remove_number_as_object_schema_helper

Conversation

@Sysix

@Sysix Sysix commented Jun 18, 2026

Copy link
Copy Markdown
Member

The helper generated just number. With the Enum approach, the generator creates a u32 with minimum: 0.0 for the JSON schema.

Sysix commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI labels Jun 18, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing 06-18-refactor_linter_remove_number_as_object_schema_helper (6a8a67e) with main (54d7f75)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix marked this pull request as ready for review June 18, 2026 20:36
@Sysix Sysix requested a review from camc314 as a code owner June 18, 2026 20:36
@Sysix Sysix force-pushed the 06-18-refactor_linter_remove_number_as_object_schema_helper branch from 39c2b83 to 5eea095 Compare June 19, 2026 08:47
@camc314 camc314 self-assigned this Jun 19, 2026
@Sysix Sysix force-pushed the 06-18-refactor_linter_remove_number_as_object_schema_helper branch from 5eea095 to 6a8a67e Compare June 20, 2026 18:52
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 20, 2026

camc314 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Merge activity

The helper generated just `number`. With the `Enum` approach, the generator creates a `u32` with `minimum: 0.0` for the JSON schema.
@graphite-app graphite-app Bot force-pushed the 06-18-refactor_linter_remove_number_as_object_schema_helper branch from 6a8a67e to 6d355ab Compare June 20, 2026 20:28
@graphite-app graphite-app Bot merged commit 6d355ab into main Jun 20, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 20, 2026
@graphite-app graphite-app Bot deleted the 06-18-refactor_linter_remove_number_as_object_schema_helper branch June 20, 2026 20:32
camc314 pushed a commit that referenced this pull request Jul 3, 2026
The helper generated just `number`. With the `Enum` approach, the generator creates a `u32` with `minimum: 0.0` for the JSON schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants