perf(parser): skip single space between tokens branchlessly#2354
Closed
overlookmotel wants to merge 1 commit into02-08-perf_parser_eat_whitespace_after_line_breakfrom
Conversation
This was referenced Feb 8, 2024
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2354 will degrade performances by 4.81%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
Well that didn't work! |
Member
|
Maybe relevant: https://v8.dev/blog/scanner#whitespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reprise of #2029. It's just easier to do now with the
SourceAPI.I'm not sure how much this will move the needle, just wanted to try it out.