Skip to content

refactor(linter/vue): extract computed getter utils into utils/vue.rs#23505

Merged
camc314 merged 1 commit into
oxc-project:mainfrom
babu-ch:refactor/vue-computed-context-utils
Jun 16, 2026
Merged

refactor(linter/vue): extract computed getter utils into utils/vue.rs#23505
camc314 merged 1 commit into
oxc-project:mainfrom
babu-ch:refactor/vue-computed-context-utils

Conversation

@babu-ch

@babu-ch babu-ch commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #23493.

Shares the computed-getter detection helpers across no-side-effects-in-computed-properties, no-async-in-computed-properties, and return-in-computed-property. The last one previously accepted arrow getters in Options API by accident — now aligned with upstream's getComputedProperties.

@babu-ch babu-ch marked this pull request as ready for review June 16, 2026 14:32
@babu-ch babu-ch requested a review from camc314 as a code owner June 16, 2026 14:32
@codspeed-hq

codspeed-hq Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing babu-ch:refactor/vue-computed-context-utils (20e0fbc) with main (ca9686b)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the A-linter Area - Linter label Jun 16, 2026
@camc314 camc314 self-assigned this Jun 16, 2026

@camc314 camc314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 merged commit 67531ac into oxc-project:main Jun 16, 2026
33 checks passed
camc314 pushed a commit that referenced this pull request Jul 3, 2026
…#23505)

Follow-up to #23493.

Shares the computed-getter detection helpers across
`no-side-effects-in-computed-properties`,
`no-async-in-computed-properties`, and `return-in-computed-property`.
The last one previously accepted arrow getters in Options API by
accident — now aligned with upstream's `getComputedProperties`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants