Skip to content

refactor(linter): separate optimized rule dispatch path#23449

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/cherry-pick-e7785625
Jun 15, 2026
Merged

refactor(linter): separate optimized rule dispatch path#23449
graphite-app[bot] merged 1 commit into
mainfrom
codex/cherry-pick-e7785625

Conversation

@camc314

@camc314 camc314 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
  • Split from perf(linter): dispatch rules in a single AST pass #23409.
  • Separates the optimized linter rule dispatch path from the unoptimized debug reference path.
  • Keeps runtime type filtering contained inside the optimized branch so the debug comparison path always runs every rule on every node.

Co-authored-by: Boshen boshenc@gmail.com

@github-actions github-actions Bot added the A-linter Area - Linter label Jun 15, 2026
@camc314 camc314 self-assigned this Jun 15, 2026
@camc314 camc314 marked this pull request as ready for review June 15, 2026 13:15
Copilot AI review requested due to automatic review settings June 15, 2026 13:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026

camc314 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 15, 1:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 15, 1:19 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jun 15, 1:22 PM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Jun 15, 1:22 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 15, 1:26 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jun 15, 1:36 PM UTC: Merged by the Graphite merge queue.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

graphite-app Bot pushed a commit that referenced this pull request Jun 15, 2026
- Split from #23409.
- Separates the optimized linter rule dispatch path from the unoptimized debug reference path.
- Keeps runtime type filtering contained inside the optimized branch so the debug comparison path always runs every rule on every node.
@graphite-app graphite-app Bot force-pushed the codex/cherry-pick-e7785625 branch from 9176599 to 7fcff29 Compare June 15, 2026 13:20
@camc314 camc314 marked this pull request as draft June 15, 2026 13:21
@camc314 camc314 force-pushed the codex/cherry-pick-e7785625 branch from 7fcff29 to b7a31cf Compare June 15, 2026 13:22
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026
@camc314 camc314 marked this pull request as ready for review June 15, 2026 13:22
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026
graphite-app Bot pushed a commit that referenced this pull request Jun 15, 2026
- Split from #23409.
- Separates the optimized linter rule dispatch path from the unoptimized debug reference path.
- Keeps runtime type filtering contained inside the optimized branch so the debug comparison path always runs every rule on every node.

Co-authored-by: Boshen <boshenc@gmail.com>
@graphite-app graphite-app Bot force-pushed the codex/cherry-pick-e7785625 branch from b7a31cf to ae33a6b Compare June 15, 2026 13:27
- Split from #23409.
- Separates the optimized linter rule dispatch path from the unoptimized debug reference path.
- Keeps runtime type filtering contained inside the optimized branch so the debug comparison path always runs every rule on every node.

Co-authored-by: Boshen <boshenc@gmail.com>
@graphite-app graphite-app Bot force-pushed the codex/cherry-pick-e7785625 branch from ae33a6b to ff77c3d Compare June 15, 2026 13:32
@graphite-app graphite-app Bot merged commit ff77c3d into main Jun 15, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026
@graphite-app graphite-app Bot deleted the codex/cherry-pick-e7785625 branch June 15, 2026 13:36
camc314 added a commit that referenced this pull request Jul 3, 2026
- Split from #23409.
- Separates the optimized linter rule dispatch path from the unoptimized debug reference path.
- Keeps runtime type filtering contained inside the optimized branch so the debug comparison path always runs every rule on every node.

Co-authored-by: Boshen <boshenc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants