Skip to content

refactor(linter): add MixedTupleRuleConfig#23396

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-13-refactor_linter_add_mixedtupleruleconfig_
Jun 15, 2026
Merged

refactor(linter): add MixedTupleRuleConfig#23396
graphite-app[bot] merged 1 commit into
mainfrom
06-13-refactor_linter_add_mixedtupleruleconfig_

Conversation

@Sysix

@Sysix Sysix commented Jun 14, 2026

Copy link
Copy Markdown
Member

Added a new struct for 3 rules:

  • eslint/func-name-matching
  • import/extension
  • react/jsx-no-script-url

These rules accept an enum configuration like:

enum ConfigOptions {
 First(Option1),
 Second(Option2),
 Both(Option1, Option2)
}

Added the new struct for eslint/func-name-matching to test if the expected result matches the upstream configuration.
Changed the rule schema generation code, so enums (subschema with any_of), will be folded, Allowing us to support the 3 rules.

Sysix commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI labels Jun 14, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing 06-13-refactor_linter_add_mixedtupleruleconfig_ (1a66bd2) with main (965358e)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix force-pushed the 06-13-refactor_linter_add_mixedtupleruleconfig_ branch 4 times, most recently from 4597f27 to 01accf5 Compare June 14, 2026 15:46
@Sysix Sysix marked this pull request as ready for review June 14, 2026 15:53
@Sysix Sysix requested a review from camc314 as a code owner June 14, 2026 15:53
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Jun 14, 2026

Sysix commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

Merge activity

@Sysix Sysix removed the 0-merge Merge with Graphite Merge Queue label Jun 14, 2026
graphite-app Bot pushed a commit that referenced this pull request Jun 14, 2026
Added a new struct for 3 rules:
- `eslint/func-name-matching`
- `import/extension`
- `react/jsx-no-script-url`

These rules accept an enum configuration like:
```rust
enum ConfigOptions {
 First(Option1),
 Second(Option2),
 Both(Option1, Option2)
}
```

Added the new struct for `eslint/func-name-matching` to test if the expected result matches the upstream configuration.
Changed the rule schema generation code, so enums (`subschema with any_of`), will be folded, Allowing us to support the 3 rules.
@graphite-app graphite-app Bot force-pushed the 06-13-refactor_linter_add_mixedtupleruleconfig_ branch from 01accf5 to 1a66bd2 Compare June 14, 2026 15:54

@camc314 camc314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Comment thread crates/oxc_linter/src/rule.rs
@camc314

camc314 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Copilot AI requested a review from camc314 June 15, 2026 16:24
camc314 pushed a commit that referenced this pull request Jun 15, 2026
Added a new struct for 3 rules:
- `eslint/func-name-matching`
- `import/extension`
- `react/jsx-no-script-url`

These rules accept an enum configuration like:
```rust
enum ConfigOptions {
 First(Option1),
 Second(Option2),
 Both(Option1, Option2)
}
```

Added the new struct for `eslint/func-name-matching` to test if the expected result matches the upstream configuration.
Changed the rule schema generation code, so enums (`subschema with any_of`), will be folded, Allowing us to support the 3 rules.
@camc314 camc314 force-pushed the 06-13-refactor_linter_add_mixedtupleruleconfig_ branch from 1a66bd2 to 574290e Compare June 15, 2026 16:35
Comment thread apps/oxlint/src-js/package/config.generated.ts
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026
Added a new struct for 3 rules:
- `eslint/func-name-matching`
- `import/extension`
- `react/jsx-no-script-url`

These rules accept an enum configuration like:
```rust
enum ConfigOptions {
 First(Option1),
 Second(Option2),
 Both(Option1, Option2)
}
```

Added the new struct for `eslint/func-name-matching` to test if the expected result matches the upstream configuration.
Changed the rule schema generation code, so enums (`subschema with any_of`), will be folded, Allowing us to support the 3 rules.
@graphite-app graphite-app Bot force-pushed the 06-13-refactor_linter_add_mixedtupleruleconfig_ branch from 38fd24d to fef29bd Compare June 15, 2026 16:53
@graphite-app graphite-app Bot merged commit fef29bd into main Jun 15, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 15, 2026
@graphite-app graphite-app Bot deleted the 06-13-refactor_linter_add_mixedtupleruleconfig_ branch June 15, 2026 16:58
camc314 pushed a commit that referenced this pull request Jul 3, 2026
Added a new struct for 3 rules:
- `eslint/func-name-matching`
- `import/extension`
- `react/jsx-no-script-url`

These rules accept an enum configuration like:
```rust
enum ConfigOptions {
 First(Option1),
 Second(Option2),
 Both(Option1, Option2)
}
```

Added the new struct for `eslint/func-name-matching` to test if the expected result matches the upstream configuration.
Changed the rule schema generation code, so enums (`subschema with any_of`), will be folded, Allowing us to support the 3 rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants