Skip to content

refactor(oxlint/lsp): remove unused Rope references#23341

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-12-refactor_oxlint_lsp_remove_unused_rope_references
Jun 12, 2026
Merged

refactor(oxlint/lsp): remove unused Rope references#23341
graphite-app[bot] merged 1 commit into
mainfrom
06-12-refactor_oxlint_lsp_remove_unused_rope_references

Conversation

@Sysix

@Sysix Sysix commented Jun 12, 2026

Copy link
Copy Markdown
Member

With the changes from #23329, Rope does not need to be created and passed into the functions.
This PR removes all references to Rope, because we never access it.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Jun 12, 2026

Sysix commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review June 12, 2026 12:48
@Sysix Sysix requested a review from camc314 as a code owner June 12, 2026 12:48
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Jun 12, 2026

Sysix commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Merge activity

With the changes from #23329, `Rope` does not need to be created and passed into the functions.
This PR removes all references to `Rope`, because we never access it.
@graphite-app graphite-app Bot force-pushed the 06-12-refactor_oxlint_lsp_remove_unused_rope_references branch from 024ac9a to 44dbcc2 Compare June 12, 2026 12:52
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks1


Comparing 06-12-refactor_oxlint_lsp_remove_unused_rope_references (024ac9a) with main (956309a)

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app Bot merged commit 44dbcc2 into main Jun 12, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 12, 2026
@graphite-app graphite-app Bot deleted the 06-12-refactor_oxlint_lsp_remove_unused_rope_references branch June 12, 2026 12:57
camc314 pushed a commit that referenced this pull request Jul 3, 2026
With the changes from #23329, `Rope` does not need to be created and passed into the functions.
This PR removes all references to `Rope`, because we never access it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant