refactor(linter/consistent-function-scoping): use Scoping::scope_is_descendant_of API#23275
Merged
graphite-app[bot] merged 1 commit intoJun 11, 2026
Conversation
Scoping::scope_is_descendant_of API
Contributor
Author
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
…descendant_of` API (#23275) Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for `consistent-function-scoping` parent-scope checks. The rule previously built a set of parent scope IDs for each function scope. The shared scoping API now expresses the same proper-descendant relationship directly, so the temporary set allocation is no longer needed.
8183a02 to
598a752
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
…descendant_of` API (#23275) Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for `consistent-function-scoping` parent-scope checks. The rule previously built a set of parent scope IDs for each function scope. The shared scoping API now expresses the same proper-descendant relationship directly, so the temporary set allocation is no longer needed.
598a752 to
5a052a2
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
…descendant_of` API (#23275) Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for `consistent-function-scoping` parent-scope checks. The rule previously built a set of parent scope IDs for each function scope. The shared scoping API now expresses the same proper-descendant relationship directly, so the temporary set allocation is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of
Scoping::scope_is_descendant_ofintroduced in #22313 forconsistent-function-scopingparent-scope checks.The rule previously built a set of parent scope IDs for each function scope. The shared scoping API now expresses the same proper-descendant relationship directly, so the temporary set allocation is no longer needed.