refactor(linter/prefer-const): use Scoping::scope_is_descendant_of API#23273
Merged
Conversation
Scoping::scope_is_descendant_of API
camc314
commented
Jun 11, 2026
camc314
left a comment
Contributor
Author
There was a problem hiding this comment.
this is so much nicer 🙂
Contributor
Author
Merge activity
|
Merging this PR will not alter performance
Comparing 
Footnotes
|
…API (#23273) Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for `prefer-const` control-flow scope checks. These call sites already checked whether a symbol scope was a proper descendant of a loop or control-flow scope, so this delegates that logic to the shared scoping API without changing behavior.
319e35e to
cc4035a
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
…API (#23273) Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for `prefer-const` control-flow scope checks. These call sites already checked whether a symbol scope was a proper descendant of a loop or control-flow scope, so this delegates that logic to the shared scoping API without changing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of
Scoping::scope_is_descendant_ofintroduced in #22313 forprefer-constcontrol-flow scope checks.These call sites already checked whether a symbol scope was a proper descendant of a loop or control-flow scope, so this delegates that logic to the shared scoping API without changing behavior.