Skip to content

refactor(linter/block-scoped-var): use Scoping::scope_is_descendant_of API#23272

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/block-scoped-var-scope-descendant
Jun 11, 2026
Merged

refactor(linter/block-scoped-var): use Scoping::scope_is_descendant_of API#23272
graphite-app[bot] merged 1 commit into
mainfrom
codex/block-scoped-var-scope-descendant

Conversation

@camc314

@camc314 camc314 commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Make use of Scoping::scope_is_descendant_of introduced in #22313 for the block-scoped-var outside-scope check.

The helper now preserves the previous same-scope behavior with an explicit equality check before delegating descendant checks to the shared scoping API.

@github-actions github-actions Bot added the A-linter Area - Linter label Jun 11, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1

Comparing codex/block-scoped-var-scope-descendant (ebd1fd0) with main (b5c71c6)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 self-assigned this Jun 11, 2026
@camc314 camc314 marked this pull request as ready for review June 11, 2026 10:00
Copilot AI review requested due to automatic review settings June 11, 2026 10:00
Copilot AI reviewed Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@camc314 camc314 changed the title refactor(linter/block-scoped-var): use scope descendant API refactor(linter/block-scoped-var): use Scoping::scope_is_descendant_of API Jun 11, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 11, 2026
@camc314 Graphite App

camc314 commented Jun 11, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

@camc314
refactor(linter/block-scoped-var): use `Scoping::scope_is_descendant_…
63b43ad 
…of` API (#23272)

Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for the `block-scoped-var` outside-scope check.

The helper now preserves the previous same-scope behavior with an explicit equality check before delegating descendant checks to the shared scoping API.
@graphite-app graphite-app Bot force-pushed the codex/block-scoped-var-scope-descendant branch from ebd1fd0 to 63b43ad Compare June 11, 2026 10:02
@graphite-app graphite-app Bot merged commit 63b43ad into main Jun 11, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 11, 2026
@graphite-app graphite-app Bot deleted the codex/block-scoped-var-scope-descendant branch June 11, 2026 10:06
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
refactor(linter/block-scoped-var): use `Scoping::scope_is_descendant_…
b0375d6 
…of` API (#23272)

Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for the `block-scoped-var` outside-scope check.

The helper now preserves the previous same-scope behavior with an explicit equality check before delegating descendant checks to the shared scoping API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314