Skip to content

refactor(linter/exhaustive-deps): use Scoping::scope_is_descendant_of API#23270

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/exhaustive-deps-scope-descendant
Jun 11, 2026
Merged

refactor(linter/exhaustive-deps): use Scoping::scope_is_descendant_of API#23270
graphite-app[bot] merged 1 commit into
mainfrom
codex/exhaustive-deps-scope-descendant

Conversation

@camc314

@camc314 camc314 commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Make use of Scoping::scope_is_descendant_of introduced in #22313 for ancestor scope checks in react/exhaustive-deps.

Both call sites already excluded the same-scope case with .skip(1), so this delegates directly to the shared scoping API without changing behavior.

@github-actions github-actions Bot added the A-linter Area - Linter label Jun 11, 2026
@camc314 camc314 changed the title refactor(linter/exhaustive-deps): use scope descendant API refactor(linter/exhaustive-deps): use Scoping::scope_is_descendant_of API Jun 11, 2026
@camc314 camc314 self-assigned this Jun 11, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 11, 2026
@camc314 camc314 marked this pull request as ready for review June 11, 2026 09:44
Copilot AI review requested due to automatic review settings June 11, 2026 09:44
@camc314 Graphite App

camc314 commented Jun 11, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

Copilot AI reviewed Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@camc314
refactor(linter/exhaustive-deps): use `Scoping::scope_is_descendant_o…
58747a3 
…f` API (#23270)

Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for ancestor scope checks in `react/exhaustive-deps`.

Both call sites already excluded the same-scope case with `.skip(1)`, so this delegates directly to the shared scoping API without changing behavior.
@graphite-app graphite-app Bot force-pushed the codex/exhaustive-deps-scope-descendant branch from 3b56fe3 to 58747a3 Compare June 11, 2026 09:50
@graphite-app graphite-app Bot merged commit 58747a3 into main Jun 11, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 11, 2026
@graphite-app graphite-app Bot deleted the codex/exhaustive-deps-scope-descendant branch June 11, 2026 09:53
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
refactor(linter/exhaustive-deps): use `Scoping::scope_is_descendant_o…
cf58fee 
…f` API (#23270)

Make use of `Scoping::scope_is_descendant_of` introduced in #22313 for ancestor scope checks in `react/exhaustive-deps`.

Both call sites already excluded the same-scope case with `.skip(1)`, so this delegates directly to the shared scoping API without changing behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314