Skip to content

refactor(linter/vue): share defineProps type-signature resolution across rules#23263

Merged
camc314 merged 2 commits into
oxc-project:mainfrom
babu-ch:refactor/vue-props-type-resolver
Jun 11, 2026
Merged

refactor(linter/vue): share defineProps type-signature resolution across rules#23263
camc314 merged 2 commits into
oxc-project:mainfrom
babu-ch:refactor/vue-props-type-resolver

Conversation

@babu-ch

@babu-ch babu-ch commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #22951.

De-duplicates the defineProps<T>() type resolution shared across several vue rules. As a result max-props, prop-name-casing and no-required-prop-with-default now also handle type aliases / unions / intersections, matching upstream.

Part of #11440.

@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing babu-ch:refactor/vue-props-type-resolver (8a67d91) with main (52d0c31)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@babu-ch babu-ch marked this pull request as ready for review June 11, 2026 06:57
@babu-ch babu-ch requested a review from camc314 as a code owner June 11, 2026 06:57
@camc314 camc314 added the A-linter Area - Linter label Jun 11, 2026
@camc314 camc314 self-assigned this Jun 11, 2026
@camc314

camc314 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@camc314 camc314 merged commit 5e532ee into oxc-project:main Jun 11, 2026
28 checks passed
camc314 added a commit that referenced this pull request Jul 3, 2026
…oss rules (#23263)

Follow-up to #22951.

De-duplicates the `defineProps<T>()` type resolution shared across
several vue rules. As a result `max-props`, `prop-name-casing` and
`no-required-prop-with-default` now also handle `type` aliases / unions
/ intersections, matching upstream.

Part of #11440.

Co-authored-by: Cameron <cameron.clark@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants