Skip to content

style(linter/react-perf): reorder imports#23226

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/06-10-style_linter_react-perf_reorder_imports
Jun 10, 2026
Merged

style(linter/react-perf): reorder imports#23226
graphite-app[bot] merged 1 commit into
mainfrom
c/06-10-style_linter_react-perf_reorder_imports

Conversation

@camc314

@camc314 camc314 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@camc314 Graphite App

camc314 commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Jun 10, 2026
Merged
@github-actions github-actions Bot added the A-linter Area - Linter label Jun 10, 2026
@camc314 camc314 marked this pull request as ready for review June 10, 2026 11:10
Copilot AI review requested due to automatic review settings June 10, 2026 11:10
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 10, 2026
@camc314 camc314 self-assigned this Jun 10, 2026
@camc314 Graphite App

camc314 commented Jun 10, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

Copilot AI reviewed Jun 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorders use statements in the react_perf linter rules to group serde::Deserialize consistently at the top of each file, aligning import layout across these rules.

Changes:

  • Move use serde::Deserialize; to the top of each affected react_perf rule module.
  • Add a separating blank line to keep import groups visually distinct.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/react_perf/jsx_no_new_object_as_prop.rs Moves serde::Deserialize import to the top for consistent import grouping.
crates/oxc_linter/src/rules/react_perf/jsx_no_new_function_as_prop.rs Moves serde::Deserialize import to the top for consistent import grouping.
crates/oxc_linter/src/rules/react_perf/jsx_no_new_array_as_prop.rs Moves serde::Deserialize import to the top for consistent import grouping.
crates/oxc_linter/src/rules/react_perf/jsx_no_jsx_as_prop.rs Moves serde::Deserialize import to the top for consistent import grouping.

@camc314 camc314 changed the base branch from main to graphite-base/23226 June 10, 2026 11:16
@camc314 camc314 force-pushed the c/06-10-style_linter_react-perf_reorder_imports branch from 36fc91f to 3d1eb45 Compare June 10, 2026 11:16
@camc314 camc314 changed the base branch from graphite-base/23226 to c/06-10-fix_linter_react-perf_re-generate_stale_snapshots June 10, 2026 11:17
@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1

Comparing c/06-10-style_linter_react-perf_reorder_imports (36fc91f) with main (5b9a793)2

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on graphite-base/23226 (5b9a793) during the generation of this report, so main (5b9a793) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@camc314 camc314 mentioned this pull request Jun 10, 2026
Merged
@graphite-app graphite-app Bot changed the base branch from c/06-10-fix_linter_react-perf_re-generate_stale_snapshots to graphite-base/23226 June 10, 2026 11:20
@graphite-app graphite-app Bot force-pushed the c/06-10-style_linter_react-perf_reorder_imports branch from 3d1eb45 to f94010e Compare June 10, 2026 11:25
@graphite-app graphite-app Bot force-pushed the graphite-base/23226 branch from 5bd22aa to 4dd52de Compare June 10, 2026 11:25
@graphite-app graphite-app Bot changed the base branch from graphite-base/23226 to main June 10, 2026 11:26
@graphite-app graphite-app Bot force-pushed the c/06-10-style_linter_react-perf_reorder_imports branch from f94010e to 92bb48f Compare June 10, 2026 11:26
@graphite-app graphite-app Bot force-pushed the c/06-10-style_linter_react-perf_reorder_imports branch from 92bb48f to 4edfd6a Compare June 10, 2026 11:31
@graphite-app graphite-app Bot merged commit 4edfd6a into main Jun 10, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 10, 2026
@graphite-app graphite-app Bot deleted the c/06-10-style_linter_react-perf_reorder_imports branch June 10, 2026 11:34
camc314 added a commit that referenced this pull request Jul 3, 2026
@camc314
style(linter/react-perf): reorder imports (#23226)
030b503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314