refactor(minifier): route all peephole mutations through typed helpers#23196
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
a4fe763 to
8e9ace2
Compare
Contributor
Merge activity
|
#23196) > Developed with AI assistance (Claude Code); reviewed, tested, and benchmarked by the contributor. ## Summary Replaces the ~190 manual `ctx.state.changed = true` writes scattered across `crates/oxc_minifier/src/peephole/` with typed mutation helpers on `MinifierTraverseCtx` (`replace_expression`, `replace_statement`, `replace_assignment_target_property`, `replace_property_key`, `replace_for_statement_left`, `drop_expression`, `drop_statement`, `drop_class_element`, `notice_change`). The mutation signal itself becomes a private `mutated: bool` on `MinifierState`, readable only via `take_mutated()` (read-and-reset in a single call) — the compiler now enforces that the fixed-point loop's signal can only be set by the helpers and only consumed by the loop driver. "Forgot to mark the loop dirty" — the bug pattern behind #22722 and #22552 — becomes structurally hard to write. The migration also carries the latent silent-mutation fixes surfaced by routing every mutation through a helper (missed `*slot = …` writes in `remove_unused_expression`, `convert_to_dotted_properties`, `minimize_statements`, and field-write bypass sites), plus idempotency gates in `try_fold_if` so the typed helpers don't block fixed-point convergence. This is stage 1 of 2 re-cutting the approach prototyped in #22736; the incremental scoping refresh stacks on top. ## Verification - `cargo test -p oxc_minifier` — 509 pass - `just minsize` — **bit-identical output** across the entire size-test corpus (this PR is a pure refactor) - `cargo coverage -- minifier` — conformance unchanged - clippy (all features/targets) clean - `allocs_minifier.snap`: small arena-only deltas (+0.02–0.08%) from helper call-site construction patterns; sys allocs unchanged
8e9ace2 to
09176f8
Compare
This was referenced Jun 16, 2026
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
#23196) > Developed with AI assistance (Claude Code); reviewed, tested, and benchmarked by the contributor. ## Summary Replaces the ~190 manual `ctx.state.changed = true` writes scattered across `crates/oxc_minifier/src/peephole/` with typed mutation helpers on `MinifierTraverseCtx` (`replace_expression`, `replace_statement`, `replace_assignment_target_property`, `replace_property_key`, `replace_for_statement_left`, `drop_expression`, `drop_statement`, `drop_class_element`, `notice_change`). The mutation signal itself becomes a private `mutated: bool` on `MinifierState`, readable only via `take_mutated()` (read-and-reset in a single call) — the compiler now enforces that the fixed-point loop's signal can only be set by the helpers and only consumed by the loop driver. "Forgot to mark the loop dirty" — the bug pattern behind #22722 and #22552 — becomes structurally hard to write. The migration also carries the latent silent-mutation fixes surfaced by routing every mutation through a helper (missed `*slot = …` writes in `remove_unused_expression`, `convert_to_dotted_properties`, `minimize_statements`, and field-write bypass sites), plus idempotency gates in `try_fold_if` so the typed helpers don't block fixed-point convergence. This is stage 1 of 2 re-cutting the approach prototyped in #22736; the incremental scoping refresh stacks on top. ## Verification - `cargo test -p oxc_minifier` — 509 pass - `just minsize` — **bit-identical output** across the entire size-test corpus (this PR is a pure refactor) - `cargo coverage -- minifier` — conformance unchanged - clippy (all features/targets) clean - `allocs_minifier.snap`: small arena-only deltas (+0.02–0.08%) from helper call-site construction patterns; sys allocs unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ~190 manual
ctx.state.changed = truewrites scattered acrosscrates/oxc_minifier/src/peephole/with typed mutation helpers onMinifierTraverseCtx(replace_expression,replace_statement,replace_assignment_target_property,replace_property_key,replace_for_statement_left,drop_expression,drop_statement,drop_class_element,notice_change).The mutation signal itself becomes a private
mutated: boolonMinifierState, readable only viatake_mutated()(read-and-reset in a single call) — the compiler now enforces that the fixed-point loop's signal can only be set by the helpers and only consumed by the loop driver."Forgot to mark the loop dirty" — the bug pattern behind #22722 and #22552 — becomes structurally hard to write. The migration also carries the latent silent-mutation fixes surfaced by routing every mutation through a helper (missed
*slot = …writes inremove_unused_expression,convert_to_dotted_properties,minimize_statements, and field-write bypass sites), plus idempotency gates intry_fold_ifso the typed helpers don't block fixed-point convergence.This is stage 1 of 2 re-cutting the approach prototyped in #22736; the incremental scoping refresh stacks on top.
Verification
cargo test -p oxc_minifier— 509 passjust minsize— bit-identical output across the entire size-test corpus (this PR is a pure refactor)cargo coverage -- minifier— conformance unchangedallocs_minifier.snap: small arena-only deltas (+0.02–0.08%) from helper call-site construction patterns; sys allocs unchanged